You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "sandbergja (via GitHub)" <gi...@apache.org> on 2025/01/08 17:26:41 UTC

[PR] [ref guide] Note how to view the requested and applied facet.method [solr]

sandbergja opened a new pull request, #2974:
URL: https://github.com/apache/solr/pull/2974

   (small docs contribution, not in jira)
   <!--
   _(If you are a project committer then you may remove some/all of the following template.)_
   
   Before creating a pull request, please file an issue in the ASF Jira system for Solr:
   
   * https://issues.apache.org/jira/projects/SOLR
   
   For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. 
   To create a Jira issue, you will need to create an account there first.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * SOLR-####: <short description of problem or changes>
   
   SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
   
   
   # Description
   
   While experimenting with some different `facet.method`s in solr, I found the `requestedMethod` and `appliedMethod` fields in the debug output very helpful.  I did not see them mentioned in the ref guide yet, so wanted to make them easier to find.
   
   # Solution
   
   Mention these debug fields in the ref guide as a note.
   
   # Tests
   
   No tests provided, it's just a documentation commit.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
   - [x] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] [ref guide] Note how to view the requested and applied facet.method [solr]

Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2974:
URL: https://github.com/apache/solr/pull/2974#issuecomment-2578285981

   Nice!  Would you mind just slapping in a screenshot of the rendered note?  I wondered if it needed a new line above the `NOTE`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] [ref guide] Note how to view the requested and applied facet.method [solr]

Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2974:
URL: https://github.com/apache/solr/pull/2974#issuecomment-2582581881

   Thank you for making Solr a better place!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] [ref guide] Note how to view the requested and applied facet.method [solr]

Posted by "sandbergja (via GitHub)" <gi...@apache.org>.
sandbergja commented on PR #2974:
URL: https://github.com/apache/solr/pull/2974#issuecomment-2578420906

   > Nice! Would you mind just slapping in a screenshot of the rendered note? I wondered if it needed a new line above the `NOTE`?
   
   ![facet.method documentation, with a note inline with the facet.method heading](https://github.com/user-attachments/assets/4f891168-41a3-4a91-9234-8ad741a3d28a)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] [ref guide] Note how to view the requested and applied facet.method [solr]

Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #2974:
URL: https://github.com/apache/solr/pull/2974


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org