You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/03/15 14:50:52 UTC
[GitHub] [bookkeeper] lhotari commented on a change in pull request #3110: PendingReadOp: Fix ledgerEntryImpl reuse problem
lhotari commented on a change in pull request #3110:
URL: https://github.com/apache/bookkeeper/pull/3110#discussion_r827065870
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
##########
@@ -110,6 +110,7 @@
@Override
public void close() {
+ complete.set(true);
Review comment:
wouldn't it be safer to use `if (complete.compareAndSet(false, true)) {` to shield against races?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org