You are viewing a plain text version of this content. The canonical link for it is here.
Posted to wss4j-dev@ws.apache.org by "Fred Dushin (JIRA)" <ji...@apache.org> on 2006/06/09 17:57:29 UTC

[jira] Created: (WSS-45) Change CryptoFactory.getInstance to support java.util.Map

Change CryptoFactory.getInstance to support java.util.Map
---------------------------------------------------------

         Key: WSS-45
         URL: http://issues.apache.org/jira/browse/WSS-45
     Project: WSS4J
        Type: Wish

    Reporter: Fred Dushin
 Assigned to: Davanum Srinivas 


The CryptoFactory type supports dynamic loading of Crypto instances through the getInstance operation (it would be more appropriate to call this "createInstance", but that's a separate issue).  The relevant operation signature is

getInstance(java.lang.String, java.util.Properties)

For implementors who would like to supply their own Crypto implementations, however, a Properties object may not be sufficient, since a Properties maps strings to strings.  It would be more general, and helpful, to define this operation to take a java.util.Map (which java.util.Properties implements), so that pre-allocated/constructed objects can be passed through this interface.

This should be a binary-compatible change (assuming the Merlin implementation is changed to downcast to a Properties object)

I would be happy to supply a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: wss4j-dev-help@ws.apache.org


[jira] Updated: (WSS-45) Change CryptoFactory.getInstance to support java.util.Map

Posted by "Fred Dushin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fred Dushin updated WSS-45:
---------------------------

    Attachment: wss4j-45.patch

This patch is against the latest trunk, and is a slightly less aggressive patch -- it only results in the addition of a new createCrypto on the CryptoFactory class, which takes a Map, and an CryptoBase abstract type, which can be used with this new operation (as well as the others).  All the Merlin stuff is left untouched.

> Change CryptoFactory.getInstance to support java.util.Map
> ---------------------------------------------------------
>
>                 Key: WSS-45
>                 URL: https://issues.apache.org/jira/browse/WSS-45
>             Project: WSS4J
>          Issue Type: Wish
>            Reporter: Fred Dushin
>         Assigned To: Davanum Srinivas
>         Attachments: crypto.diff, wss4j-45.patch
>
>
> The CryptoFactory type supports dynamic loading of Crypto instances through the getInstance operation (it would be more appropriate to call this "createInstance", but that's a separate issue).  The relevant operation signature is
> getInstance(java.lang.String, java.util.Properties)
> For implementors who would like to supply their own Crypto implementations, however, a Properties object may not be sufficient, since a Properties maps strings to strings.  It would be more general, and helpful, to define this operation to take a java.util.Map (which java.util.Properties implements), so that pre-allocated/constructed objects can be passed through this interface.
> This should be a binary-compatible change (assuming the Merlin implementation is changed to downcast to a Properties object)
> I would be happy to supply a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: wss4j-dev-help@ws.apache.org


[jira] Updated: (WSS-45) Change CryptoFactory.getInstance to support java.util.Map

Posted by "Fred Dushin (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/WSS-45?page=all ]

Fred Dushin updated WSS-45:
---------------------------

    Attachment: crypto.diff


Unified diff file to resolve this enhancement request.

This diff affects the following elements:
Index: src/org/apache/ws/security/components/crypto/AbstractCrypto.java
Index: src/org/apache/ws/security/components/crypto/Merlin.java
Index: src/org/apache/ws/security/components/crypto/CryptoFactory.java
Index: src/org/apache/ws/security/components/crypto/CryptoBase.java [new]

These patches were generated against tag 1_5_0.

> Change CryptoFactory.getInstance to support java.util.Map
> ---------------------------------------------------------
>
>                 Key: WSS-45
>                 URL: http://issues.apache.org/jira/browse/WSS-45
>             Project: WSS4J
>          Issue Type: Wish
>            Reporter: Fred Dushin
>         Assigned To: Davanum Srinivas
>         Attachments: crypto.diff
>
>
> The CryptoFactory type supports dynamic loading of Crypto instances through the getInstance operation (it would be more appropriate to call this "createInstance", but that's a separate issue).  The relevant operation signature is
> getInstance(java.lang.String, java.util.Properties)
> For implementors who would like to supply their own Crypto implementations, however, a Properties object may not be sufficient, since a Properties maps strings to strings.  It would be more general, and helpful, to define this operation to take a java.util.Map (which java.util.Properties implements), so that pre-allocated/constructed objects can be passed through this interface.
> This should be a binary-compatible change (assuming the Merlin implementation is changed to downcast to a Properties object)
> I would be happy to supply a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: wss4j-dev-help@ws.apache.org


[jira] Updated: (WSS-45) Change CryptoFactory.getInstance to support java.util.Map

Posted by "Fred Dushin (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/WSS-45?page=all ]

Fred Dushin updated WSS-45:
---------------------------

    Attachment: crypto.diff


Unified diff file to resolve this enhancement request.

This diff affects the following elements:
Index: src/org/apache/ws/security/components/crypto/AbstractCrypto.java
Index: src/org/apache/ws/security/components/crypto/Merlin.java
Index: src/org/apache/ws/security/components/crypto/CryptoFactory.java
Index: src/org/apache/ws/security/components/crypto/CryptoBase.java [new]

These patches were generated against tag 1_5_0.

> Change CryptoFactory.getInstance to support java.util.Map
> ---------------------------------------------------------
>
>                 Key: WSS-45
>                 URL: http://issues.apache.org/jira/browse/WSS-45
>             Project: WSS4J
>          Issue Type: Wish
>            Reporter: Fred Dushin
>         Assigned To: Davanum Srinivas
>         Attachments: crypto.diff
>
>
> The CryptoFactory type supports dynamic loading of Crypto instances through the getInstance operation (it would be more appropriate to call this "createInstance", but that's a separate issue).  The relevant operation signature is
> getInstance(java.lang.String, java.util.Properties)
> For implementors who would like to supply their own Crypto implementations, however, a Properties object may not be sufficient, since a Properties maps strings to strings.  It would be more general, and helpful, to define this operation to take a java.util.Map (which java.util.Properties implements), so that pre-allocated/constructed objects can be passed through this interface.
> This should be a binary-compatible change (assuming the Merlin implementation is changed to downcast to a Properties object)
> I would be happy to supply a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: wss4j-dev-help@ws.apache.org


[jira] Resolved: (WSS-45) Change CryptoFactory.getInstance to support java.util.Map

Posted by "Ruchith Udayanga Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruchith Udayanga Fernando resolved WSS-45.
------------------------------------------

    Resolution: Fixed

Applied the attached patch : 
http://svn.apache.org/viewvc?view=rev&rev=522265

Thanks,
Ruchith

> Change CryptoFactory.getInstance to support java.util.Map
> ---------------------------------------------------------
>
>                 Key: WSS-45
>                 URL: https://issues.apache.org/jira/browse/WSS-45
>             Project: WSS4J
>          Issue Type: Wish
>            Reporter: Fred Dushin
>         Assigned To: Davanum Srinivas
>         Attachments: crypto.diff, wss4j-45.patch
>
>
> The CryptoFactory type supports dynamic loading of Crypto instances through the getInstance operation (it would be more appropriate to call this "createInstance", but that's a separate issue).  The relevant operation signature is
> getInstance(java.lang.String, java.util.Properties)
> For implementors who would like to supply their own Crypto implementations, however, a Properties object may not be sufficient, since a Properties maps strings to strings.  It would be more general, and helpful, to define this operation to take a java.util.Map (which java.util.Properties implements), so that pre-allocated/constructed objects can be passed through this interface.
> This should be a binary-compatible change (assuming the Merlin implementation is changed to downcast to a Properties object)
> I would be happy to supply a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: wss4j-dev-help@ws.apache.org


[jira] Updated: (WSS-45) Change CryptoFactory.getInstance to support java.util.Map

Posted by "Fred Dushin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fred Dushin updated WSS-45:
---------------------------

    Attachment: wss4j-45.patch

This patch is against the latest trunk, and is a slightly less aggressive patch -- it only results in the addition of a new createCrypto on the CryptoFactory class, which takes a Map, and an CryptoBase abstract type, which can be used with this new operation (as well as the others).  All the Merlin stuff is left untouched.

> Change CryptoFactory.getInstance to support java.util.Map
> ---------------------------------------------------------
>
>                 Key: WSS-45
>                 URL: https://issues.apache.org/jira/browse/WSS-45
>             Project: WSS4J
>          Issue Type: Wish
>            Reporter: Fred Dushin
>         Assigned To: Davanum Srinivas
>         Attachments: crypto.diff, wss4j-45.patch
>
>
> The CryptoFactory type supports dynamic loading of Crypto instances through the getInstance operation (it would be more appropriate to call this "createInstance", but that's a separate issue).  The relevant operation signature is
> getInstance(java.lang.String, java.util.Properties)
> For implementors who would like to supply their own Crypto implementations, however, a Properties object may not be sufficient, since a Properties maps strings to strings.  It would be more general, and helpful, to define this operation to take a java.util.Map (which java.util.Properties implements), so that pre-allocated/constructed objects can be passed through this interface.
> This should be a binary-compatible change (assuming the Merlin implementation is changed to downcast to a Properties object)
> I would be happy to supply a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: wss4j-dev-help@ws.apache.org


[jira] Resolved: (WSS-45) Change CryptoFactory.getInstance to support java.util.Map

Posted by "Ruchith Udayanga Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruchith Udayanga Fernando resolved WSS-45.
------------------------------------------

    Resolution: Fixed

Applied the attached patch : 
http://svn.apache.org/viewvc?view=rev&rev=522265

Thanks,
Ruchith

> Change CryptoFactory.getInstance to support java.util.Map
> ---------------------------------------------------------
>
>                 Key: WSS-45
>                 URL: https://issues.apache.org/jira/browse/WSS-45
>             Project: WSS4J
>          Issue Type: Wish
>            Reporter: Fred Dushin
>         Assigned To: Davanum Srinivas
>         Attachments: crypto.diff, wss4j-45.patch
>
>
> The CryptoFactory type supports dynamic loading of Crypto instances through the getInstance operation (it would be more appropriate to call this "createInstance", but that's a separate issue).  The relevant operation signature is
> getInstance(java.lang.String, java.util.Properties)
> For implementors who would like to supply their own Crypto implementations, however, a Properties object may not be sufficient, since a Properties maps strings to strings.  It would be more general, and helpful, to define this operation to take a java.util.Map (which java.util.Properties implements), so that pre-allocated/constructed objects can be passed through this interface.
> This should be a binary-compatible change (assuming the Merlin implementation is changed to downcast to a Properties object)
> I would be happy to supply a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: wss4j-dev-help@ws.apache.org