You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/07/27 09:27:08 UTC

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #845: MINIFICPP-1277 - Create cross-platform API for querying memory usage

hunyadi-dev commented on a change in pull request #845:
URL: https://github.com/apache/nifi-minifi-cpp/pull/845#discussion_r460762421



##########
File path: libminifi/include/utils/OsUtils.h
##########
@@ -31,6 +31,12 @@ namespace OsUtils {
  */
 extern std::string userIdToUsername(const std::string &uid);
 
+/**
+ * Returns memory usage in bytes
+ */
+

Review comment:
       The comment is useful, but it might be better as a single line comment
   ```c++
   // Returns memory usage in bytes
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org