You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/12/16 08:20:31 UTC
Review Request 71916: Removed outdated check assuming no reservations
with disks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71916/
-----------------------------------------------------------
Review request for mesos and Benno Evers.
Repository: mesos
Description
-------
Since `disk` resources can be re-reserved we need to allow for them to
appear in `RESERVE` operations. The validity of the operation and the
resources appearing in them are already check elsewhere and the check
removed here was intended more as a sanity check/avenue to create a
better error message. With re-reservations it is now incorrect.
Diffs
-----
src/master/validation.cpp c5fbbdd55e4a217c756e2ece3f8fd6ed5e88048f
Diff: https://reviews.apache.org/r/71916/diff/1/
Testing
-------
* `make check`
* tested re-reserving a `disk` resource in a test cluster with authorization enabled
Thanks,
Benjamin Bannier
Re: Review Request 71916: Removed outdated check assuming no
reservations with disks.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71916/#review219036
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On Dec. 16, 2019, 8:20 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71916/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2019, 8:20 a.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since `disk` resources can be re-reserved we need to allow for them to
> appear in `RESERVE` operations. The validity of the operation and the
> resources appearing in them are already check elsewhere and the check
> removed here was intended more as a sanity check/avenue to create a
> better error message. With re-reservations it is now incorrect.
>
>
> Diffs
> -----
>
> src/master/validation.cpp c5fbbdd55e4a217c756e2ece3f8fd6ed5e88048f
>
>
> Diff: https://reviews.apache.org/r/71916/diff/1/
>
>
> Testing
> -------
>
> * `make check`
> * tested re-reserving a `disk` resource in a test cluster with authorization enabled
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71916: Removed outdated check assuming no
reservations with disks.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71916/#review219037
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71916]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Dec. 16, 2019, 1:50 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71916/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2019, 1:50 p.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since `disk` resources can be re-reserved we need to allow for them to
> appear in `RESERVE` operations. The validity of the operation and the
> resources appearing in them are already check elsewhere and the check
> removed here was intended more as a sanity check/avenue to create a
> better error message. With re-reservations it is now incorrect.
>
>
> Diffs
> -----
>
> src/master/validation.cpp c5fbbdd55e4a217c756e2ece3f8fd6ed5e88048f
>
>
> Diff: https://reviews.apache.org/r/71916/diff/1/
>
>
> Testing
> -------
>
> * `make check`
> * tested re-reserving a `disk` resource in a test cluster with authorization enabled
>
>
> Thanks,
>
> Benjamin Bannier
>
>