[GitHub] [flink] dawidwys commented on a change in pull request #14681: [FLINK-21009] Can not disable certain options in Elasticsearch 7 connector

[GitBox <gi...@apache.org>]

dawidwys commented on a change in pull request #14681:
URL: https://github.com/apache/flink/pull/14681#discussion_r559614428



##########
File path: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
##########
@@ -402,6 +405,18 @@ protected BulkProcessor buildBulkProcessor(BulkProcessor.Listener listener) {
         return bulkProcessorBuilder.build();
     }
 
+    private void configureBulkSize(BulkProcessor.Builder bulkProcessorBuilder) {

Review comment:
       Honestly, I'd rather extract a method for `bulkProcessorFlushIntervalMillis`. I feel strong about long methods. Personally I like when methods have a limited responsibilities. When reading the `buildBulkProcessor` we do not need to think how exactly is the bulk size configured. WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org