You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by witgo <gi...@git.apache.org> on 2014/09/04 06:09:14 UTC
[GitHub] spark pull request: [SPARK-3397] Bump pom.xml version number of ma...
GitHub user witgo opened a pull request:
https://github.com/apache/spark/pull/2268
[SPARK-3397] Bump pom.xml version number of master branch to 1.2.0-SNAPSHOT
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/witgo/spark SPARK-3397
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2268.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2268
----
commit eaf913f19ca86663085779b63430b1d21b553585
Author: GuoQiang Li <wi...@qq.com>
Date: 2014-09-04T04:06:31Z
Bump pom.xml version number of master branch to 1.2.0-SNAPSHOT
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3397] Bump pom.xml version number of ma...
Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2268#issuecomment-54478364
When we resolve and target jira for master its against 1.2, so why isn't the pom version updated? If its a release process detail, can we change it. I find it confusing that when I build against master its older then when I build against branch-1.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3397] Bump pom.xml version number of ma...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2268#issuecomment-54729941
Checked with Patrick and this looks good, so I'm going to merge it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3397] Bump pom.xml version number of ma...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2268#issuecomment-54547967
Actually, I think this is the right fix. Commits that are targeted for 1.1.0 go into `branch-1.1`, while development for 1.2.0 is continuing on `master`, so we probably should have updated the pom.xml versions when we created `branch-1.1` itself, not when we released 1.1.0, so that the _first_ commit/revision that's in 1.2.0 and not in 1.1.0 has the right version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3397] Bump pom.xml version number of ma...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2268
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3397] Bump pom.xml version number of ma...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2268#issuecomment-54766446
Aha! There was a [hardcoded "1.1" string in MimaExcludes](https://github.com/apache/spark/blob/f2b5b619a9efee91573c0e546792e68e72afce21/project/MimaExcludes.scala#L36):
```scala
def excludes(version: String) =
version match {
case v if v.startsWith("1.1") =>
Seq(
MimaBuild.excludeSparkPackage("deploy"),
MimaBuild.excludeSparkPackage("graphx")
) ++
...
```
I guess this logic serves to exclude certain incompatibilities introduced in Spark 1.1.
What's the right fix here (beyond just rolling back the version numbers, which I'll probably do in the interim)?
At the time of release, 1.1.0 should be binary-compatible with 1.0.0. Therefore, when testing 1.2.0-SNAPSHOT, is it safe to just [update the previousSparkVersion] (https://github.com/apache/spark/blob/f2b5b619a9efee91573c0e546792e68e72afce21/project/MimaBuild.scala#L88) to 1.1.0 and start with an empty set of excludes if `v.startsWith(1.2)`? This might have to wait until 1.1.0 is published on Maven.
/cc @pwendell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3397] Bump pom.xml version number of ma...
Posted by witgo <gi...@git.apache.org>.
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/2268#issuecomment-54441310
@srowen I agree with you. But [SparkContext.SPARK_VERSION](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/SparkContext.scala#L1300) has been modified to `1.2.0-SNAPSHOT`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3397] Bump pom.xml version number of ma...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2268#issuecomment-54556330
Yeah I think it's reasonable to bump the versions in master now rather than wait for the release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3397] Bump pom.xml version number of ma...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2268#issuecomment-54432582
@witgo The release process does this, I believe. I don't think you need to open a PR for this especially before 1.1.0 is released
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3397] Bump pom.xml version number of ma...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2268#issuecomment-54766066
It looks like this somehow broke the MiMa binary compatibility tests. I noticed that I merged this without first checking whether Jenkins had run; sorry about that! I'm going to dig in and see if I can figure out why this is causing failures...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3397] Bump pom.xml version number of ma...
Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2268#issuecomment-54671834
@pwendell do you just want to run the set version and commit it or do you want to do it through this jira?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org