[GitHub] [arrow] emkornfield commented on a diff in pull request #36972: GH-36939: [C++][Parquet] Boolean encoding has inconsistent implemention

["emkornfield (via GitHub)" <gi...@apache.org>]

emkornfield commented on code in PR #36972:
URL: https://github.com/apache/arrow/pull/36972#discussion_r1285148898


##########
cpp/src/parquet/encoding_test.cc:
##########
@@ -882,6 +894,12 @@ TYPED_TEST(EncodingAdHocTyped, PlainArrowDirectPut) {
   }
 }
 
+TYPED_TEST(EncodingAdHocTyped, PlainArrowDirectPutMultiRound) {
+  for (auto seed : {0, 1, 2, 3, 4, 5, 6, 7, 8, 9}) {

Review Comment:
   A random test is great but it would be nice to have a direct test which demonstrates the regression and fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org