[jira] [Commented] (SOLR-8420) Date statistics: sumOfSquares overflows long

["Christine Poerschke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069489#comment-15069489 ] 

Christine Poerschke commented on SOLR-8420:
-------------------------------------------

sumOfSquares overflow, interesting. I wonder if {{DateStatsValues}}'s {{private long sum = 0;}} might perhaps become {{double}} also (similar to {{NumericStatsValues}}'s sum being a double already).

> Date statistics: sumOfSquares overflows long
> --------------------------------------------
>
>                 Key: SOLR-8420
>                 URL: https://issues.apache.org/jira/browse/SOLR-8420
>             Project: Solr
>          Issue Type: Bug
>          Components: SearchComponents - other
>    Affects Versions: 5.4
>            Reporter: Tom Hill
>            Priority: Minor
>         Attachments: 0001-Fix-overflow-in-date-statistics.patch, 0001-Fix-overflow-in-date-statistics.patch, StdDev.java
>
>
> The values for Dates are large enough that squaring them overflows a "long" field. This should be converted to a double. 
> StatsValuesFactory.java, line 755 DateStatsValues#updateTypeSpecificStats Add a cast to double 
> sumOfSquares += ( (double)value * value * count);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org