You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Marco Massenzio <ma...@mesosphere.io> on 2015/07/10 09:58:46 UTC
Review Request 36389: [WIP] Enable remote execution of arbitrary
command.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36389/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Cody Maloney.
Repository: mesos
Description
-------
Jira: MESOS-2830
Under certain (maintenance) circumnstance, it may be necessary
(or desirable) to execute arbitrary operator's commands on the
slave (the entire fleet or a subset thereof) bypassing the Mesos
Task execution mechanism; this may typically be necessary for
maintenance and/or emergency actions.
This patch adds an HTTP endpoint (/execute) which accepts a
JSON-encoded CommandInfo structure and executes the given
command (with optional arguments).
The output of the command (along with potentially any stderr
messages) is returned JSON-encoded in the Response.
For more details, see the design doc at:
https://goo.gl/4npTMU
Diffs
-----
src/slave/slave.hpp dec4ca8323e151a6d0f9139214ff0ef6e3e3375a
src/slave/slave.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4
Diff: https://reviews.apache.org/r/36389/diff/
Testing
-------
make check
lots of manual testing (using Postman, REST client)
Thanks,
Marco Massenzio
Re: Review Request 36389: [WIP] Enable remote execution of arbitrary
command.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36389/#review91278
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36389]
All tests passed.
- Mesos ReviewBot
On July 10, 2015, 7:59 a.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36389/
> -----------------------------------------------------------
>
> (Updated July 10, 2015, 7:59 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Cody Maloney.
>
>
> Bugs: MESOS-2830
> https://issues.apache.org/jira/browse/MESOS-2830
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Jira: MESOS-2830
>
> Under certain (maintenance) circumnstance, it may be necessary
> (or desirable) to execute arbitrary operator's commands on the
> slave (the entire fleet or a subset thereof) bypassing the Mesos
> Task execution mechanism; this may typically be necessary for
> maintenance and/or emergency actions.
>
> This patch adds an HTTP endpoint (/execute) which accepts a
> JSON-encoded CommandInfo structure and executes the given
> command (with optional arguments).
>
> The output of the command (along with potentially any stderr
> messages) is returned JSON-encoded in the Response.
>
> For more details, see the design doc at:
> https://goo.gl/4npTMU
>
>
> Diffs
> -----
>
> src/slave/slave.hpp dec4ca8323e151a6d0f9139214ff0ef6e3e3375a
> src/slave/slave.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4
>
> Diff: https://reviews.apache.org/r/36389/diff/
>
>
> Testing
> -------
>
> make check
>
> lots of manual testing (using Postman, REST client)
>
>
> Thanks,
>
> Marco Massenzio
>
>
Re: Review Request 36389: [WIP] Enable remote execution of arbitrary
command.
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36389/
-----------------------------------------------------------
(Updated July 10, 2015, 7:59 a.m.)
Review request for mesos, Benjamin Hindman and Cody Maloney.
Bugs: MESOS-2830
https://issues.apache.org/jira/browse/MESOS-2830
Repository: mesos
Description
-------
Jira: MESOS-2830
Under certain (maintenance) circumnstance, it may be necessary
(or desirable) to execute arbitrary operator's commands on the
slave (the entire fleet or a subset thereof) bypassing the Mesos
Task execution mechanism; this may typically be necessary for
maintenance and/or emergency actions.
This patch adds an HTTP endpoint (/execute) which accepts a
JSON-encoded CommandInfo structure and executes the given
command (with optional arguments).
The output of the command (along with potentially any stderr
messages) is returned JSON-encoded in the Response.
For more details, see the design doc at:
https://goo.gl/4npTMU
Diffs
-----
src/slave/slave.hpp dec4ca8323e151a6d0f9139214ff0ef6e3e3375a
src/slave/slave.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4
Diff: https://reviews.apache.org/r/36389/diff/
Testing
-------
make check
lots of manual testing (using Postman, REST client)
Thanks,
Marco Massenzio