You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by bourneagain <gi...@git.apache.org> on 2015/10/16 04:08:37 UTC
[GitHub] storm pull request: STORM-1071 Task Message format to include sour...
GitHub user bourneagain opened a pull request:
https://github.com/apache/storm/pull/803
STORM-1071 Task Message format to include source task id
As part of gathering inputs for Resource Aware Scheduler, understanding the tuple network characteristics between tasks would be helpful.
The present implementation of TaskMessage includes only the destination task id and message. Including the source task id to it would help us understand the task-task (component/component) network bandwidth characteristics. It shall also avoid the deserialization of message to retrieve the source task id from the serialized tuple message.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bourneagain/storm STORM-1071
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/803.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #803
----
commit 7f4d32959a77fff57d5be4872fe27d83829a2314
Author: Shyam Rajendran <sr...@yahoo-inc.com>
Date: 2015-10-16T00:47:28Z
STORM-1071 Task Message format to include source task id
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1071 Task Message format to include sour...
Posted by bourneagain <gi...@git.apache.org>.
Github user bourneagain commented on the pull request:
https://github.com/apache/storm/pull/803#issuecomment-148811510
I see with present changes, when I performed the unit test, netty ```test-basic``` and ```test-large-msg``` work fine but ```test-batch``` fails if we go over 1000 messages. I could also see ```org.apache.maven.plugin.MojoExecutionException: Clojure failed.```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1071 Task Message format to include sour...
Posted by bourneagain <gi...@git.apache.org>.
Github user bourneagain commented on the pull request:
https://github.com/apache/storm/pull/803#issuecomment-148789458
I see I should be updating netty_unit_test.clj to prevent the Travis CI build failures. I shall push an update soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---