You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/10/12 16:42:36 UTC

[PR] Minor: Update LogicalPlan::join_on API, use it more [arrow-datafusion]

alamb opened a new pull request, #7814:
URL: https://github.com/apache/arrow-datafusion/pull/7814

   ## Which issue does this PR close?
   
   Related to https://github.com/apache/arrow-datafusion/issues/7766, follow on to https://github.com/apache/arrow-datafusion/pull/7805
   
   ## Rationale for this change
   
   @jackwener suggested in https://github.com/apache/arrow-datafusion/pull/7805/files#r1356685435 that the newly added `LogicalPlan::join_on` API could be used more widely:
   
   > There are more code can be like this.
   > 
   > like `join_on_false()` .....
   
   
   
   
   ## What changes are included in this PR?
   1. Use `join_on` more widely. 
   2. Chang the API of LogicalPlan::join_on to match `DataFrame::join_on` and take an iterator of Exprs rather than just an Expr. 
   
   ## Are these changes tested?
   
   Covered by existing tests
   
   ## Are there any user-facing changes?
   Since the API change in https://github.com/apache/arrow-datafusion/pull/7805 has not been released, this is not a end-user visible API change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Minor: Update LogicalPlan::join_on API, use it more [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7814:
URL: https://github.com/apache/arrow-datafusion/pull/7814#issuecomment-1761667913

   Thank you for the review @jackwener 🙏 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Minor: Update LogicalPlan::join_on API, use it more [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #7814:
URL: https://github.com/apache/arrow-datafusion/pull/7814


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org