[GitHub] [airflow] uranusjr commented on a diff in pull request #32819: Handle logout by auth manager

["uranusjr (via GitHub)" <gi...@apache.org>]

uranusjr commented on code in PR #32819:
URL: https://github.com/apache/airflow/pull/32819#discussion_r1272875208


##########
airflow/www/extensions/init_security.py:
##########
@@ -70,5 +69,4 @@ def init_check_user_active(app):
     @app.before_request
     def check_user_active():
         if get_auth_manager().is_logged_in() and not g.user.is_active:
-            logout_user()
-            return redirect(get_auth_manager().get_url_login())
+            return redirect(get_auth_manager().get_url_logout())

Review Comment:
   This change doesn’t looks right?



##########
airflow/www/extensions/init_security.py:
##########
@@ -70,5 +69,4 @@ def init_check_user_active(app):
     @app.before_request
     def check_user_active():
         if get_auth_manager().is_logged_in() and not g.user.is_active:
-            logout_user()
-            return redirect(get_auth_manager().get_url_login())
+            return redirect(get_auth_manager().get_url_logout())

Review Comment:
   This change doesn’t looks right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org