[GitHub] [ratis] codings-dan commented on a diff in pull request #666: RATIS-1603. TimeoutScheduler can have a huge amount of threads and cause OOM.

[GitBox <gi...@apache.org>]

codings-dan commented on code in PR #666:
URL: https://github.com/apache/ratis/pull/666#discussion_r938436857


##########
ratis-common/src/main/java/org/apache/ratis/util/TimeoutScheduler.java:
##########
@@ -32,7 +31,7 @@
 import java.util.function.Consumer;
 import java.util.function.Supplier;
 
-public final class TimeoutScheduler implements Closeable {
+public final class TimeoutScheduler implements TimeoutExecutor {

Review Comment:
   Should we remove this class, it will cause thread overflow and should not be called again



##########
ratis-common/src/main/java/org/apache/ratis/util/TimeoutExecutor.java:
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.ratis.util;
+
+import org.apache.ratis.util.function.CheckedRunnable;
+import org.slf4j.Logger;
+
+import java.util.function.Consumer;
+import java.util.function.Supplier;
+
+/** Execute timeout tasks. */
+public interface TimeoutExecutor {
+  int MAXIMUM_POOL_SIZE =  8;
+  static TimeoutExecutor getInstance() {
+    return TimeoutTimer.getInstance();
+  }
+
+  /** @return the number of scheduled but not completed timeout tasks. */
+  int getQueueSize();

Review Comment:
   should we rename it to getTaskCount or a more explicit method name?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org