[jira] [Commented] (LIBCLOUD-896) Add ENA support for images in EC2 compute driver

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LIBCLOUD-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859934#comment-15859934 ] 

ASF GitHub Bot commented on LIBCLOUD-896:
-----------------------------------------

GitHub user amisstea opened a pull request:

    https://github.com/apache/libcloud/pull/983

    [LIBCLOUD-896] Added ENA support to images in EC2 compute driver.

    ## Added ENA support to images in EC2 compute driver.
    
    ### Description
    
    Please refer to: https://issues.apache.org/jira/browse/LIBCLOUD-896
    
    Bumping the EC2 API version was necessary to support the new ENA options. I performed some spot checking of the test fixtures against the API reference docs and didn't notice any breaking changes. If there are some comprehensive functional tests to prove this I am willing to run them.
    
    ### Status
    
    done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [x] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amisstea/libcloud libcloud-896_ec2-ena-support

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/983.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #983
    
----
commit e7e1aa784fd66ef98d85f3a7db3648d639e64d22
Author: Alex Misstear <am...@redhat.com>
Date:   2017-02-09T17:19:14Z

    [LIBCLOUD-896] Added ENA support to images in EC2 compute driver.
    Bumped the EC2 API version to support ENA.

----


> Add ENA support for images in EC2 compute driver
> ------------------------------------------------
>
>                 Key: LIBCLOUD-896
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-896
>             Project: Libcloud
>          Issue Type: Improvement
>          Components: Compute
>            Reporter: Alex Misstear
>            Priority: Minor
>
> AWS added a new feature called Elastic Network Adapters:
> https://aws.amazon.com/blogs/aws/elastic-network-adapter-high-performance-network-interface-for-amazon-ec2/
> I propose adding support for this in the EC2 compute driver. Specifically, this would include updating the ex_register_image and list_images methods to support setting and retrieving the EnaSupport flag, respectively.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)