You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/02/14 09:08:18 UTC
[GitHub] [maven-doxia-sitetools] cstamas opened a new pull request #29: Update to mvn 3.2.5
cstamas opened a new pull request #29:
URL: https://github.com/apache/maven-doxia-sitetools/pull/29
Just a simple draft: minimal changes to update to mvn 3.2.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] michael-o edited a comment on pull request #29: Update to mvn 3.2.5
Posted by GitBox <gi...@apache.org>.
michael-o edited a comment on pull request #29:
URL: https://github.com/apache/maven-doxia-sitetools/pull/29#issuecomment-1038962493
> Is still needed:
>
> ```
> if ( isMaven3OrMore() ) ...
> ```
>
> and corresponding code in: `org.apache.maven.doxia.tools.DefaultSiteTool#getParentProject`
Good catch, this can go away as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] slawekjaranowski commented on pull request #29: Update to mvn 3.2.5
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #29:
URL: https://github.com/apache/maven-doxia-sitetools/pull/29#issuecomment-1038954445
Is still needed:
```
if ( isMaven3OrMore() ) ...
```
and corresponding code in: `org.apache.maven.doxia.tools.DefaultSiteTool#getParentProject`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] cstamas commented on a change in pull request #29: Update to mvn 3.2.5
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #29:
URL: https://github.com/apache/maven-doxia-sitetools/pull/29#discussion_r805760659
##########
File path: doxia-integration-tools/pom.xml
##########
@@ -131,6 +145,74 @@
<artifactId>maven-plugin-testing-harness</artifactId>
<version>1.1</version>
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] slachiewicz commented on a change in pull request #29: Update to mvn 3.2.5
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on a change in pull request #29:
URL: https://github.com/apache/maven-doxia-sitetools/pull/29#discussion_r805698577
##########
File path: doxia-integration-tools/pom.xml
##########
@@ -131,6 +145,74 @@
<artifactId>maven-plugin-testing-harness</artifactId>
<version>1.1</version>
Review comment:
3.3.9?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] gnodet commented on a change in pull request #29: [DOXIASITETOOLS-243] Drop Maven2 bits, update to Maven 3.2.5
Posted by GitBox <gi...@apache.org>.
gnodet commented on a change in pull request #29:
URL: https://github.com/apache/maven-doxia-sitetools/pull/29#discussion_r805771695
##########
File path: doxia-integration-tools/pom.xml
##########
@@ -56,28 +56,37 @@
<groupId>org.apache.maven</groupId>
<artifactId>maven-artifact</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
- <artifactId>maven-artifact-manager</artifactId>
+ <artifactId>maven-core</artifactId>
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
- <artifactId>maven-model</artifactId>
+ <artifactId>maven-compat</artifactId>
+ <version>${mavenVersion}</version>
+ <scope>provided</scope>
Review comment:
Can't we drop this dependency to maven-compat ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] cstamas commented on a change in pull request #29: Update to mvn 3.2.5
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #29:
URL: https://github.com/apache/maven-doxia-sitetools/pull/29#discussion_r805739665
##########
File path: doxia-integration-tools/pom.xml
##########
@@ -131,6 +145,74 @@
<artifactId>maven-plugin-testing-harness</artifactId>
<version>1.1</version>
Review comment:
I think you are mixing up -harness and -tools?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] michael-o commented on pull request #29: Update to mvn 3.2.5
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #29:
URL: https://github.com/apache/maven-doxia-sitetools/pull/29#issuecomment-1038962493
> Is still needed:
>
> ```
> if ( isMaven3OrMore() ) ...
> ```
>
> and corresponding code in: `org.apache.maven.doxia.tools.DefaultSiteTool#getParentProject`
Good catch, this can go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] michael-o commented on pull request #29: [DOXIASITETOOLS-243] Drop Maven2 bits, update to Maven 3.2.5
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #29:
URL: https://github.com/apache/maven-doxia-sitetools/pull/29#issuecomment-1039086828
@cstamas Do you want to work on the compat removal or shall we merge this and handle compat separately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] michael-o closed pull request #29: [DOXIASITETOOLS-243] Drop Maven2 bits, update to Maven 3.2.5
Posted by GitBox <gi...@apache.org>.
michael-o closed pull request #29:
URL: https://github.com/apache/maven-doxia-sitetools/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] michael-o commented on a change in pull request #29: Update to mvn 3.2.5
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #29:
URL: https://github.com/apache/maven-doxia-sitetools/pull/29#discussion_r805633075
##########
File path: doxia-integration-tools/src/test/java/org/apache/maven/doxia/tools/SiteToolTest.java
##########
@@ -51,6 +53,12 @@
public class SiteToolTest
extends PlexusTestCase
{
+ @Override
+ protected void customizeContainerConfiguration( @SuppressWarnings( "unused" ) final ContainerConfiguration configuration )
+ {
+ configuration.setClassPathScanning( PlexusConstants.SCANNING_CACHE );
Review comment:
That was my mistake, I simply missed this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] cstamas commented on a change in pull request #29: [DOXIASITETOOLS-243] Drop Maven2 bits, update to Maven 3.2.5
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #29:
URL: https://github.com/apache/maven-doxia-sitetools/pull/29#discussion_r805796976
##########
File path: doxia-integration-tools/pom.xml
##########
@@ -56,28 +56,37 @@
<groupId>org.apache.maven</groupId>
<artifactId>maven-artifact</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
- <artifactId>maven-artifact-manager</artifactId>
+ <artifactId>maven-core</artifactId>
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
- <artifactId>maven-model</artifactId>
+ <artifactId>maven-compat</artifactId>
+ <version>${mavenVersion}</version>
+ <scope>provided</scope>
Review comment:
Yup, should be simple to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] michael-o commented on a change in pull request #29: Update to mvn 3.2.5
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #29:
URL: https://github.com/apache/maven-doxia-sitetools/pull/29#discussion_r805633346
##########
File path: doxia-integration-tools/pom.xml
##########
@@ -131,6 +145,74 @@
<artifactId>maven-plugin-testing-harness</artifactId>
<version>1.1</version>
Review comment:
Maybe go straight to 3.3.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] michael-o commented on a change in pull request #29: Update to mvn 3.2.5
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #29:
URL: https://github.com/apache/maven-doxia-sitetools/pull/29#discussion_r805740449
##########
File path: doxia-integration-tools/pom.xml
##########
@@ -131,6 +145,74 @@
<artifactId>maven-plugin-testing-harness</artifactId>
<version>1.1</version>
Review comment:
Yes, I think you are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org