You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by bu...@apache.org on 2007/05/03 14:23:17 UTC
DO NOT REPLY [Bug 42326] New: - Order of elements in .jmx files changes with no reason
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42326>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42326
Summary: Order of elements in .jmx files changes with no reason
Product: JMeter
Version: 2.2
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: major
Priority: P2
Component: Main
AssignedTo: jmeter-dev@jakarta.apache.org
ReportedBy: jens@voss-ahrensburg.de
When you open a saved test plan with JMeter and immediately save it again
(under a new name), often many test elements change their positions in the .jmx
file (see attached screenshot of diff tool). This makes putting test plans
under version control a farce.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 42326] - Order of elements in .jmx files changes with no reason
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42326>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42326
------- Additional Comments From jens@voss-ahrensburg.de 2007-05-31 04:04 -------
Created an attachment (id=20296)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20296&action=view)
Patch to the previously supplied patch
Okay, I guess my previous patch simply went a bit too far.
In order to correct it, apply the new patch to revision 542902 of the
AbstractTestElement class.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 42326] - Order of elements in .jmx files changes with no reason
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42326>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42326
------- Additional Comments From jens@voss-ahrensburg.de 2007-05-03 05:28 -------
I tried hacking around the source code a bit, replacing HashMaps by
LinkedHashMaps in places that looked promising, but it didn't seem to fix the
problem, and unfortunately I currently don't have time for thorough debugging
and fixing
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 42326] - Order of elements in .jmx files changes with no reason
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42326>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42326
------- Additional Comments From sebb@apache.org 2007-05-03 05:34 -------
As you found, the problem is that the test plan is saved in a hash tree, and
it is non-trivial to fix (if it is possible).
This is not a JMeter bug, so changing to enhancement.
The re-ordering might disappear once the equals() and hashcode() methods are
regularised. But when I attempted that some while back, various problems
appeared.
As a work-round, you could write an XSLT sheet to order the JMX before saving
it.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 42326] - Order of elements in .jmx files changes with no reason
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42326>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42326
sebb@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution| |FIXED
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 42326] - Order of elements in .jmx files changes with no reason
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42326>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42326
------- Additional Comments From jens@voss-ahrensburg.de 2007-05-03 05:25 -------
Created an attachment (id=20116)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20116&action=view)
Screenshot of diff tool
In total, there are 168 such pseudo-differences in one .jmx file (7193 lines)
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 42326] - Order of elements in .jmx files changes with no reason
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42326>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42326
------- Additional Comments From jens@voss-ahrensburg.de 2007-05-31 03:41 -------
Hmm, I installed nightly build r542903 and tried to open saved test plans (both
saved with old versions and with the current nightly), and I reproducably get a
ConcurrentModificationException:
2007/05/31 12:34:41 ERROR - jmeter.JMeter: Failure loading test file
java.util.ConcurrentModificationException
at java.util.LinkedHashMap$LinkedHashIterator.nextEntry
(LinkedHashMap.java:365)
at java.util.LinkedHashMap$ValueIterator.next(LinkedHashMap.java:380)
at org.apache.jmeter.testelement.property.PropertyIteratorImpl.next
(PropertyIteratorImpl.java:50)
at org.apache.jmeter.testelement.AbstractTestElement.mergeIn
(AbstractTestElement.java:276)
at org.apache.jmeter.testelement.AbstractTestElement.addTestElement
(AbstractTestElement.java:115)
at org.apache.jmeter.testelement.TestPlan.addTestElement
(TestPlan.java:222)
at org.apache.jmeter.gui.tree.JMeterTreeModel.addSubTree
(JMeterTreeModel.java:83)
at org.apache.jmeter.gui.GuiPackage.addSubTree(GuiPackage.java:457)
at org.apache.jmeter.gui.action.Load.insertLoadedTree(Load.java:141)
at org.apache.jmeter.gui.action.Load.insertLoadedTree(Load.java:168)
at org.apache.jmeter.JMeter.startGui(JMeter.java:226)
at org.apache.jmeter.JMeter.start(JMeter.java:314)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.apache.jmeter.NewDriver.main(NewDriver.java:183)
Why this does not happen at my "privately patched" version here I don't really
know, but it may have to do with the fact that the rest of my sources are more
or less in 2.2 state. I'll install the source files from the current nightly
and give it another try. For now, you may probably want to rollback the
AbstractTestElement because the above error is a definite showstopper for the
nightly (unless you want to take the effort and find a fix to the
ConcurrentModificationException without rolling back the changes introduced
with the patch).
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 42326] - Order of elements in .jmx files changes with no reason
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42326>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42326
sebb@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
------- Additional Comments From sebb@apache.org 2007-05-30 11:37 -------
Thanks very much - I've applied the patch to SVN in r542902.
I'll create a nightly build later - perhaps you could check it out and report
back?
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 42326] - Order of elements in .jmx files changes with no reason
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42326>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42326
------- Additional Comments From sebb@apache.org 2007-05-31 15:40 -------
OK, applied in r543291.
Unfortunately the test suite did not detect this error. It seems to affect
only GUI tests, and the test cases don't (can't) use the GUI.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 42326] - Order of elements in .jmx files changes with no reason
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42326>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42326
------- Additional Comments From jens@voss-ahrensburg.de 2007-05-30 03:48 -------
Created an attachment (id=20287)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20287&action=view)
Patch to core\org\apache\jmeter\testelement\AbstractTestElement.java
Okay, the supplied patch should do the job.
Note that if you open a file (e.g. "foo.jmx") that has previously been saved
with an unpatched version and save it with the patched version (as "bar.jmx"),
there will (most likely) still be plenty of XML elements interchanged. However,
if you then open "bar.jmx" again and save it as "baz.jmx", the files "bar.jmx"
and "baz.jmx" should be identical.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org