[jclouds] marker should be null when there are no more items (#822)

[Ka-Hing Cheung <no...@github.com>]

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/822

-- Commit Summary --

  * marker should be null when there are no more items

-- File Changes --

    M apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/blobstore/RegionScopedSwiftBlobStore.java (4)
    M apis/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/blobstore/integration/SwiftContainerIntegrationLiveTest.java (7)
    M blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseContainerIntegrationTest.java (2)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/822.patch
https://github.com/jclouds/jclouds/pull/822.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/822

Re: [jclouds] marker should be null when there are no more items (#822)

[Andrew Gaul <no...@github.com>]

:+1:

@zack-shoylev any comments?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/822#issuecomment-123438852

Re: [jclouds] marker should be null when there are no more items (#822)

[Andrew Gaul <no...@github.com>]

> @@ -187,6 +187,8 @@ public void testListContainerMarker() throws InterruptedException {
>                 container);
>           assert container.getNextMarker() == null;
>  
> +         container = view.getBlobStore().list(containerName, afterMarker("z"));
> +         assert container.getNextMarker() == null;

Could you write this as `assertThat(container.getNextMarker()).isNotNull()` for a more informative error message?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/822/files#r35139182

Re: [jclouds] marker should be null when there are no more items (#822)

[Ka-Hing Cheung <no...@github.com>]

> @@ -187,6 +187,8 @@ public void testListContainerMarker() throws InterruptedException {
>                 container);
>           assert container.getNextMarker() == null;
>  
> +         container = view.getBlobStore().list(containerName, afterMarker("z"));
> +         assert container.getNextMarker() == null;

done

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/822/files#r35145972