[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1657: MINIFICPP-2207 HttpRequestMethod should be an enum

["fgerlits (via GitHub)" <gi...@apache.org>]

fgerlits commented on code in PR #1657:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1657#discussion_r1326119501


##########
libminifi/include/utils/BaseHTTPClient.h:
##########
@@ -178,6 +178,12 @@ namespace HTTPRequestResponse {
   int seek_callback(void *p, int64_t offset, int);
 }
 
+#undef DELETE  // this is a macro in winnt.h

Review Comment:
   The macro comes from `SSLContextService.h` <- `windows.h` <- `windef.h` <- `minwindef.h` <- `winnt.h`.
   
   We could add the `#undef` in SSLContextService, but that could easily break later.  Or we could replace all 30+ `#include <windows.h>` lines with a wrapper, but that should be a separate PR (and could still break if someone in the future forgets to use the wrapper).
   
   I think the easiest and safest option is to do the `#undef` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org