You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by "vy (via GitHub)" <gi...@apache.org> on 2025/10/03 12:20:06 UTC

Re: [PR] Fix: prevent ThrowableStackTraceRenderer from throwing NPEs [logging-log4j2]

vy commented on code in PR #3934:
URL: https://github.com/apache/logging-log4j2/pull/3934#discussion_r2401711710


##########
log4j-core-test/pom.xml:
##########
@@ -347,6 +347,12 @@
       <scope>test</scope>
     </dependency>
 
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito-inline</artifactId>
+      <scope>test</scope>
+    </dependency>
+

Review Comment:
   I think we can test this anomaly without overriding `final` methods – see 0ba25694d, which also ensures this will be checked in all `{ExtendedThrowable,RootThrowable,Throwable}PatternConverterTest` classes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org