[jira] [Commented] (HBASE-20789) TestBucketCache#testCacheBlockNextBlockMetadataMissing is flaky

["Zheng Hu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-20789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523699#comment-16523699 ] 

Zheng Hu commented on HBASE-20789:
----------------------------------

[~zyork],  I'm digging the flaky ut, which was introduced by HBASE-20447,  I read  the patch for HBASE-20447... and found that I did not quite understand the patch :-(   ...

{code}
        int comparison = BlockCacheUtil.validateBlockAddition(existingBlock, cachedItem, cacheKey);
        if (comparison != 0) {
          if (comparison < 0) {
            LOG.warn("Cached block contents differ by nextBlockOnDiskSize. Keeping cached block.");
            return;
          } else {
            LOG.warn("Cached block contents differ by nextBlockOnDiskSize. Caching new block.");
          }
{code} 
Why can just keep the existing cached block and return  when  existingBlock.nextBlockOnDiskSize < cachedItem.nextBlockOnDiskSize ...  actually ,  [~yuzhihong@gmail.com] asked the same question [1] , seem not answered .. 

1. https://issues.apache.org/jira/browse/HBASE-20447?focusedCommentId=16441782&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16441782



> TestBucketCache#testCacheBlockNextBlockMetadataMissing is flaky
> ---------------------------------------------------------------
>
>                 Key: HBASE-20789
>                 URL: https://issues.apache.org/jira/browse/HBASE-20789
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>            Priority: Major
>
> The UT failed frequently in our internal branch-2... Will dig into the UT.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)