[jira] [Commented] (GUACAMOLE-2326) Configure checks fail with FreeRDP 3.31 due to deprecated declarations

["Basco (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GUACAMOLE-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18117940#comment-18117940 ] 

Basco commented on GUACAMOLE-2326:
----------------------------------

Could this be why after upgrading my ubuntu 24.04 and freerdp 3.31 was installed that guac stopped working?

> Configure checks fail with FreeRDP 3.31 due to deprecated declarations
> ----------------------------------------------------------------------
>
>                 Key: GUACAMOLE-2326
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-2326
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacamole-server
>            Reporter: Ondrej Holy
>            Priority: Major
>
> Currently, guacamole-server build fails with the latest freerdp fails with `'freerdp' \{aka 'struct rdp_freerdp'} has no member named 'input'`. This is because FreeRDP 3.31 marked `SEC_WINPR_NTLM_SETTINGS` and `SEC_WINPR_KERBEROS_SETTINGS` as deprecated in `winpr/sspi.h`and including `<freerdp/freerdp.h>` triggers `-Wdeprecated-declarations` warnings. Combined with `-Werror` used in the configure checks, this causes `FREERDP_HAS_CONTEXT` and `freerdp_settings_set_pointer` feature detection to incorrectly return `no`, leading to build failures. To fix this issue `-Wno-deprecated-declarations` needs to be added alongside `-Werror` in the FreeRDP configure checks so that deprecated declarations in FreeRDP headers don't break feature detection.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)