You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/18 17:07:05 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request, #6469: wireless/bcm43xxx: remove global variable for bcmf_sdio_thread
anchao opened a new pull request, #6469:
URL: https://github.com/apache/incubator-nuttx/pull/6469
## Summary
wireless/bcm43xxx: remove global variable for bcmf_sdio_thread
## Impact
N/A
## Testing
bcm43013 iperf test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6469: wireless/bcm43xxx: remove global variable for bcmf_sdio_thread
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6469:
URL: https://github.com/apache/incubator-nuttx/pull/6469#discussion_r901014101
##########
drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.c:
##########
@@ -774,11 +769,13 @@ int bcmf_bus_sdio_initialize(FAR struct bcmf_dev_s *priv,
/* Spawn bcmf daemon thread */
+ snprintf(arg1, 16, "%p", priv);
Review Comment:
Optional
```suggestion
snprintf(arg1, sizeof(arg1), "%p", priv);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6469: wireless/bcm43xxx: remove global variable for bcmf_sdio_thread
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #6469:
URL: https://github.com/apache/incubator-nuttx/pull/6469#discussion_r901013755
##########
drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.c:
##########
@@ -868,7 +865,8 @@ void bcmf_sdio_waitdog_timeout(wdparm_t arg)
int bcmf_sdio_thread(int argc, char **argv)
{
- FAR struct bcmf_dev_s *priv = g_sdio_priv;
+ FAR struct bcmf_dev_s *priv = (FAR struct bcmf_dev_s *)
+ ((uintptr_t)strtoul(argv[1], NULL, 0));
Review Comment:
Done
##########
drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.c:
##########
@@ -774,11 +769,13 @@ int bcmf_bus_sdio_initialize(FAR struct bcmf_dev_s *priv,
/* Spawn bcmf daemon thread */
+ snprintf(arg1, 16, "0x%" PRIxPTR, (uintptr_t)priv);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6469: wireless/bcm43xxx: remove global variable for bcmf_sdio_thread
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6469:
URL: https://github.com/apache/incubator-nuttx/pull/6469#discussion_r901010359
##########
drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.c:
##########
@@ -868,7 +865,8 @@ void bcmf_sdio_waitdog_timeout(wdparm_t arg)
int bcmf_sdio_thread(int argc, char **argv)
{
- FAR struct bcmf_dev_s *priv = g_sdio_priv;
+ FAR struct bcmf_dev_s *priv = (FAR struct bcmf_dev_s *)
+ ((uintptr_t)strtoul(argv[1], NULL, 0));
Review Comment:
```suggestion
((uintptr_t)strtoul(argv[1], NULL, 16));
```
##########
drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.c:
##########
@@ -774,11 +769,13 @@ int bcmf_bus_sdio_initialize(FAR struct bcmf_dev_s *priv,
/* Spawn bcmf daemon thread */
+ snprintf(arg1, 16, "0x%" PRIxPTR, (uintptr_t)priv);
Review Comment:
I think `%p` should also give the same result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6469: wireless/bcm43xxx: remove global variable for bcmf_sdio_thread
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6469:
URL: https://github.com/apache/incubator-nuttx/pull/6469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6469: wireless/bcm43xxx: remove global variable for bcmf_sdio_thread
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #6469:
URL: https://github.com/apache/incubator-nuttx/pull/6469#discussion_r901015142
##########
drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.c:
##########
@@ -774,11 +769,13 @@ int bcmf_bus_sdio_initialize(FAR struct bcmf_dev_s *priv,
/* Spawn bcmf daemon thread */
+ snprintf(arg1, 16, "%p", priv);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org