You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by GitBox <gi...@apache.org> on 2020/10/28 07:04:42 UTC
[GitHub] [ant] TheConstructor opened a new pull request #140: #64854 Add preserveduplicates option to ResourceList
TheConstructor opened a new pull request #140:
URL: https://github.com/apache/ant/pull/140
I propose this to solve https://bz.apache.org/bugzilla/show_bug.cgi?id=64854
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] TheConstructor commented on pull request #140: #64854 Add preserveduplicates option to ResourceList
Posted by GitBox <gi...@apache.org>.
TheConstructor commented on pull request #140:
URL: https://github.com/apache/ant/pull/140#issuecomment-718039282
I just send the e-mail with the ICLA. Feel free to improve my code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] TheConstructor commented on pull request #140: #64854 Add preserveduplicates option to ResourceList
Posted by GitBox <gi...@apache.org>.
TheConstructor commented on pull request #140:
URL: https://github.com/apache/ant/pull/140#issuecomment-739563468
I checked that `cachedResources` is only ever accessed through `cache()`, which is `synchronized`. Is this really a problem? Would declaring `cachedResources` `volatile` and/or assigning the field just after populating the cache help in your opinion?
To your nits:
- I am happy to change the name
- I wasn't quite sure which version could be next, so I thought it would be good to have something in place, where I can pick up work. -> will insert the version
- Ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #140: #64854 Add preserveduplicates option to ResourceList
Posted by GitBox <gi...@apache.org>.
bodewig commented on pull request #140:
URL: https://github.com/apache/ant/pull/140#issuecomment-739559178
You removed the `volatile` attribute `cached´ from `ResourceList`. Th way code is structured now there is a race-condition where one thread my be using a cache that hasn't been initialized completely. I'm afraid you need to bring back `cached` redundant as it may seem.
Apart from that I've only got a few nits:
* I'm not sure about the name `WriteableResourceCollection` - `AppendableResourceCollection` maybe?
* please add since markers with 1.10.10 to new classes/methods and to the manual
* more importantly, add yourself to CONTRIBUTORS (plain text) and contributors.xml. The files are supposed to be ordered lexicographically by first name.
Many thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] TheConstructor commented on pull request #140: #64854 Add preserveduplicates option to ResourceList
Posted by GitBox <gi...@apache.org>.
TheConstructor commented on pull request #140:
URL: https://github.com/apache/ant/pull/140#issuecomment-739739737
@bodewig Thank you again for looking into this and my other PR!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #140: #64854 Add preserveduplicates option to ResourceList
Posted by GitBox <gi...@apache.org>.
bodewig commented on pull request #140:
URL: https://github.com/apache/ant/pull/140#issuecomment-739723211
I completely overlooked `cache` was synchronized. Since all read an write operations on `cachedResources` are synchronized, I don't think a problem exists there. Sorry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig merged pull request #140: #64854 Add preserveduplicates option to ResourceList
Posted by GitBox <gi...@apache.org>.
bodewig merged pull request #140:
URL: https://github.com/apache/ant/pull/140
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org