You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2023/05/26 05:53:10 UTC

[GitHub] [arrow] wgtmac commented on issue #35776: [C++][Parquet] Should we support PARQUET_2_8 version?

wgtmac commented on issue #35776:
URL: https://github.com/apache/arrow/issues/35776#issuecomment-1563844398

   To provide some facts:
   
   It seems that the `WriterProperties` does not check if any feature does not belong to a certain version. I have only observed several places it was checked:
   
   https://github.com/apache/arrow/blob/2d32efeedad88743dd635ff562c65e072cfb44f7/cpp/src/parquet/column_writer.cc#L2062-L2072
   
   https://github.com/apache/arrow/blob/2d32efeedad88743dd635ff562c65e072cfb44f7/cpp/src/parquet/metadata.cc#L1467-L1470
   
   https://github.com/apache/arrow/blob/2d32efeedad88743dd635ff562c65e072cfb44f7/cpp/src/parquet/arrow/schema.cc#L319-L323
   
   parquet-mr does not recognize any 2.x format version and always hardcodes version 1 to the footer metadata:
   
   https://github.com/apache/parquet-mr/blob/d5a4ce05643e6709312e3060838cb9236e882014/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java#L1339-L1343


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org