You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/10/14 14:40:31 UTC

[GitHub] [incubator-eventmesh] horoc opened a new pull request, #1580: [ISSUE #1545] Replace plugin config loading method with common utils

horoc opened a new pull request, #1580:
URL: https://github.com/apache/incubator-eventmesh/pull/1580

   
   Fixes #1545 
   
   ### Motivation
   
   1. add charset param to common loading method.
   2. add unit test of common loading method.
   3. replace plugin config loading method with common loading method
   
   ### Modifications
   
   #1545 
   
   ### Documentation
   
   None
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] horoc commented on pull request #1580: [ISSUE #1545] Replace plugin config loading method with common utils

Posted by GitBox <gi...@apache.org>.
horoc commented on PR #1580:
URL: https://github.com/apache/incubator-eventmesh/pull/1580#issuecomment-1279725299

   > please split several small pull request for these files changed too much, thanks. @horoc
   
   @xwm1992  Ok, I will submit several PRs of different plugins


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] horoc closed pull request #1580: [ISSUE #1545] Replace plugin config loading method with common utils

Posted by GitBox <gi...@apache.org>.
horoc closed pull request #1580: [ISSUE #1545] Replace plugin config loading method with common utils
URL: https://github.com/apache/incubator-eventmesh/pull/1580


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #1580: [ISSUE #1545] Replace plugin config loading method with common utils

Posted by GitBox <gi...@apache.org>.
xwm1992 commented on PR #1580:
URL: https://github.com/apache/incubator-eventmesh/pull/1580#issuecomment-1279643305

   please split several small pull request for these files changed too much, thanks. @horoc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org