You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/10/24 10:13:01 UTC
[GitHub] [cassandra-website] hemidactylus opened a new pull request, #185: A dedicated "events" section on Cassandra website
hemidactylus opened a new pull request, #185:
URL: https://github.com/apache/cassandra-website/pull/185
This is a proposed "Events" section on the Cassandra website, listing (approved) events as small cards with a picture, a short description and a link to the external event website.
The motivation behind this idea, which was discussed briefly on the cassandra-website Slack channel as well, is twofold: on one hand, it is desirable to provide this information to website visitors, which helps building the community through dedicated events; on the other hand, the Cassandra blog is preferrably not 'clogged' with too many event announcements so that it can retain its primary "technical" role.
I tried to create a page that blends in with the rest of the website experience, but while doing so I had to make some choices. In particular, I propose an icon for the section (a circus tent) that I hope conveys a "playful but not silly" message; moreover, I added the "Events" page to the "Community" navbar menu to avoid adding another menu, even though all other "Community" menu items are from the community page.
Also I am aware that the buttons alignment on the cards is imperfect. I blame my (very limited) css knowledge, this is of course something to improve if ever this draft gets accepted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] dchenbecker commented on pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
dchenbecker commented on PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#issuecomment-1289807651
Agreed, we can save expanding the criteria a future discussion. Otherwise, the changes look good to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] hemidactylus commented on a diff in pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
hemidactylus commented on code in PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#discussion_r1006845863
##########
site-content/source/modules/ROOT/pages/events.adoc:
##########
@@ -0,0 +1,277 @@
+= Events
+:page-layout: events
+:page-role: events
+
+////
+NOTES FOR CONTENT CREATORS
+- To add a new event card, copy and paste markup for one card below. Copy from '//start' to the next '//end'
+- Replace event card fields: title, date, image, short text and external link.
+////
+
+//start card
+[openblock,card shadow relative test]
+----
+[openblock,card-header]
+------
+[discrete]
+=== Cassandra Summit 2023
+[discrete]
+==== March 13-14, 2023
+------
+[openblock,card-content]
+------
+image:events/c_summit_logo.png[Cassandra Summit logo]
+
+Cassandra Summit is back! Let's meet in San Jose, California, to celebrate what we built together and share what's coming next.
+
+[openblock,card-btn card-btn--events]
+--------
+[.btn.btn--alt]
+https://events.linuxfoundation.org/cassandra-summit/[Go to event,window=_blank]
Review Comment:
Hmm, I don't know the answer. I honestly assumed that external links would be good out-of-the-box here as they are on blog posts.
(a general warning "you're leaving the site" would be best handled by client-side code, which would be a feature to implement independently from individual external links).
I took care to have external links open in new tab all the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] dchenbecker commented on pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
dchenbecker commented on PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#issuecomment-1289063929
@hemidactylus I like the page, but I feel like I'm still missing where in the PR you've added or linked to an existing page that lists criteria for approval of an event. As an organizer of a (hypothetical) event, it would be great to be able to review requirements before I submit something to the PMC. If we don't yet have such a page/list of criteria, I'm OK with that being a separate discussion, but I think that the current anchor target of "https://www.apache.org/foundation/marks/events.html#approval" just links back to itself, right? Sorry if I'm missing something obvious here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] hemidactylus commented on pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
hemidactylus commented on PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#issuecomment-1289028735
Good point @dchenbecker ! This should be opening in a new tab, I'm going to fix that now.
As for the page this anchor links to, the page I put there is the one I used as a starting point when making sure our events were meeting all requirements before submitting them to the Apache PMC for approval.
The short text on the page ("If you are organizing ...") is there precisely to stress the goal of this page to be an aggregation point for all relevant events, with 'community' as the common denominator. In this way, a visitor can see them all (regardless of location and organizer) instead of having them scattered among blog posts.
Of course I would be more than happy to reformulate this small paragraph (where I improvised a bit) if there is preference for expressing it differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] ErickRamirezAU closed pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
ErickRamirezAU closed pull request #185: A dedicated "events" section on Cassandra website
URL: https://github.com/apache/cassandra-website/pull/185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] hemidactylus commented on a diff in pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
hemidactylus commented on code in PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#discussion_r1006847756
##########
site-ui/src/layouts/events.hbs:
##########
@@ -0,0 +1,73 @@
+<!DOCTYPE html>
+<html lang="en">
+ <head>
+{{> head-first}}
+ <title>Apache Cassandra{{#with site.title}} | {{this}}{{/with}}</title>
+ {{#with (canonical-url)}}
+ <link rel="canonical" href="{{this}}">
+ <link href="https://fonts.googleapis.com/css2?family=Open+Sans:ital,wght@0,400;0,700;1,400&family=Red+Hat+Display:ital,wght@0,400;0,500;0,700;1,400;1,500&display=swap" rel="stylesheet">
+ {{/with}}
+{{> head-last}}
+ <script defer src="https://cdnjs.cloudflare.com/ajax/libs/list.js/1.0.2/list.min.js"></script>
+ </head>
+ <body class="{{page.layout}}">
+ <div class="container mx-auto relative">
+ {{> header }}
+ <div class="hero hero--home grad">
+ <div class="eye"></div>
+ <div id="home-content" class="text-center flex flex-center flex-column relative z2 ma-xlarge">
+ <h1>{{ page.title }}</h1>
+ </div>
+ </div>
+ <section id="events-main" class="arrow py-large">
+ <div class="inner">
+ <p class="text-center"><a href="https://events.linuxfoundation.org/cassandra-summit" target="_blank"><img src="{{{uiRootPath}}}/img/summit-2023-1296x512.png" alt="Cassandra Summit 2023" class="events-banner"/></a></p>
+ <p class="py-large text-center">
+ Cassandra events bring the community together. Everyone (whether they are an individual user, contributor, or company) is welcome to attend and help organize these events. They are an opportunity for users, enthusiasts, and community members to share their experiences working with Cassandra daily, hear talks and participate whether they are beginners or experts.
+ </p>
+ <p class="py-large text-center">
+ Organizing an event or want to get involved? <a href="{{{ site.url }}}/_/community.html#discussions">Get in touch with us</a>!
+ </p>
+
+ <div id="all-tiles" class="grid-list-wide list pb-large">
+ {{{page.contents}}}
+ </div>
+ </div>
+ </section>
+
+ {{> footer}}
+ </div>
+ </body>
+<script>
+jQuery(function(){
+ var cards = $('#all-tiles').find('.card');
+ var searchString = '';
+
+ // these will be external links, so comment:
+ // $(document)
+ // .on('click','.card',function(){
+ // var link = $(this).find('a').attr('href');
+ // window.open(link, '_blank');
+ // // window.location = link ;
+ // });
+
+ // $( "#search-field" ).keyup(function() {
+ // $('.card').removeClass('hidden');
+ // var val = $(this).val();
+ // val = val.toLowerCase();
+ // searchString = val;
+ // filterCards(searchString)
+ // });
+ var filterCards = function(searchString){
+ cards.each(function(){
+ var el = $(this);
+ var title = el.find('.discrete').text();
+ title = title.toLowerCase();
+ if(!title.includes(searchString)){
+ el.addClass('hidden');
+ }
+ });
+ }
+});
Review Comment:
I copied this over from a similar behaviour on the blog page.
There, a search box appears on the page to filter the entries (client-side).
At the moment, this event page has not enough entries to justify a search box, but perhaps in the future it could (or a filtering based on some geography tags of items, something like that could be useful). So I did not delete it all away but kept it for future reinstatement.
Of course this can be removed completely for cleanliness, nothing against that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] dchenbecker commented on pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
dchenbecker commented on PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#issuecomment-1288981556
OK, I missed on my first reading, but it looks like it's a self-anchor to "https://www.apache.org/foundation/marks/events.html#approval", which I don't actually see in the events page adoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] dchenbecker commented on pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
dchenbecker commented on PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#issuecomment-1289066052
@hemidactylus sorry, I just realized it's a separate link. That links to the Apache criteria for use of trademark, right? Is that temporary until we have something specific for the Cassandra PMC approval?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] ErickRamirezAU commented on a diff in pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
ErickRamirezAU commented on code in PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#discussion_r1007780332
##########
site-content/source/modules/ROOT/pages/download.adoc:
##########
@@ -18,14 +18,14 @@
[discrete]
==== Download the latest Apache Cassandra 4.0 GA release:
[discrete]
-====== Released on 2022-08-25
+====== Released on 2022-10-23
Review Comment:
I gave up and submitted a new patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] ErickRamirezAU commented on a diff in pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
ErickRamirezAU commented on code in PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#discussion_r1007464952
##########
site-content/source/modules/ROOT/pages/download.adoc:
##########
@@ -18,14 +18,14 @@
[discrete]
==== Download the latest Apache Cassandra 4.0 GA release:
[discrete]
-====== Released on 2022-08-25
+====== Released on 2022-10-23
Review Comment:
I honestly don't know how those snuck into this PR. They weren't part of any of the commits. I need to investigate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] josh-mckenzie commented on a diff in pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
josh-mckenzie commented on code in PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#discussion_r1007052432
##########
site-content/source/modules/ROOT/pages/download.adoc:
##########
@@ -18,14 +18,14 @@
[discrete]
==== Download the latest Apache Cassandra 4.0 GA release:
[discrete]
-====== Released on 2022-08-25
+====== Released on 2022-10-23
Review Comment:
Figured as much. What are implications to these diffs in this PR here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] hemidactylus commented on a diff in pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
hemidactylus commented on code in PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#discussion_r1006843530
##########
site-content/source/modules/ROOT/pages/blog/Apache-Cassandra-4.1-Features-Guardrails-Framework.adoc:
##########
@@ -70,7 +70,7 @@ Warnings :
Guardrail tables violated: Creating table t6, current number of tables 6 exceeds warning threshold of 5.
```
-However, if the hard limit is reached, the user operation will be aborted with a `GuardrailViolatedException`, preventing the potentially harmful operation from happening. Continuing with the previous example, if we have a hard limit of ten tables (`tables_warn_threshold: 10`) and we try to create an eleventh table, we will see an error and the eleventh table won’t be created:
+However, if the hard limit is reached, the user operation will be aborted with a `GuardrailViolatedException`, preventing the potentially harmful operation from happening. Continuing with the previous example, if we have a hard limit of ten tables (`tables_fail_threshold: 10`) and we try to create an eleventh table, we will see an error and the eleventh table won’t be created:
Review Comment:
This seems to be the fix to https://issues.apache.org/jira/browse/CASSANDRA-17936 which was indeed merged a few days ago already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] ErickRamirezAU commented on a diff in pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
ErickRamirezAU commented on code in PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#discussion_r1007530391
##########
site-content/source/modules/ROOT/pages/download.adoc:
##########
@@ -18,14 +18,14 @@
[discrete]
==== Download the latest Apache Cassandra 4.0 GA release:
[discrete]
-====== Released on 2022-08-25
+====== Released on 2022-10-23
Review Comment:
I don't know what's going on but I suspect it had something to do with the `rebase` I did to squash the commits. 🤦♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] dchenbecker commented on pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
dchenbecker commented on PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#issuecomment-1288978146
That sounds reasonable, @michaelsembwever . Does the linked "Must be approved by the Cassandra PMC" page have clear criteria for approval? If that link points to https://cwiki.apache.org/confluence/display/CASSANDRA/Cassandra+Project+Governance, I don't see event listing criteria there, although I think it's OK if those criteria are discussed in a separate thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] hemidactylus commented on pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
hemidactylus commented on PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#issuecomment-1289074274
I think at the moment this is all there is, as I am not aware of any Cassandra-specific set of requirements.
At least, the process I went through when seeking approval has been based on the general provisions listed in steps 1 through 5 on the linked paragraph.
I agree with you that a clear set of requirements and a short how-to specific to Cassandra would encourage more and better community events and make the process smoother. And probably, at that point, the Events page would be a good place to host such information. My impression, however, is that that would deserve its own PR and a separate discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] michaelsembwever commented on a diff in pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on code in PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#discussion_r1006885384
##########
site-content/source/modules/ROOT/pages/download.adoc:
##########
@@ -18,14 +18,14 @@
[discrete]
==== Download the latest Apache Cassandra 4.0 GA release:
[discrete]
-====== Released on 2022-08-25
+====== Released on 2022-10-23
Review Comment:
the release manager manually updates them
e.g. like this: https://github.com/apache/cassandra-website/commit/4212d0c8652852988d2026bb4b92c42f862a4dbf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] dchenbecker commented on a diff in pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
dchenbecker commented on code in PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#discussion_r1006825393
##########
site-ui/src/layouts/events.hbs:
##########
@@ -0,0 +1,73 @@
+<!DOCTYPE html>
+<html lang="en">
+ <head>
+{{> head-first}}
+ <title>Apache Cassandra{{#with site.title}} | {{this}}{{/with}}</title>
+ {{#with (canonical-url)}}
+ <link rel="canonical" href="{{this}}">
+ <link href="https://fonts.googleapis.com/css2?family=Open+Sans:ital,wght@0,400;0,700;1,400&family=Red+Hat+Display:ital,wght@0,400;0,500;0,700;1,400;1,500&display=swap" rel="stylesheet">
+ {{/with}}
+{{> head-last}}
+ <script defer src="https://cdnjs.cloudflare.com/ajax/libs/list.js/1.0.2/list.min.js"></script>
+ </head>
+ <body class="{{page.layout}}">
+ <div class="container mx-auto relative">
+ {{> header }}
+ <div class="hero hero--home grad">
+ <div class="eye"></div>
+ <div id="home-content" class="text-center flex flex-center flex-column relative z2 ma-xlarge">
+ <h1>{{ page.title }}</h1>
+ </div>
+ </div>
+ <section id="events-main" class="arrow py-large">
+ <div class="inner">
+ <p class="text-center"><a href="https://events.linuxfoundation.org/cassandra-summit" target="_blank"><img src="{{{uiRootPath}}}/img/summit-2023-1296x512.png" alt="Cassandra Summit 2023" class="events-banner"/></a></p>
+ <p class="py-large text-center">
+ Cassandra events bring the community together. Everyone (whether they are an individual user, contributor, or company) is welcome to attend and help organize these events. They are an opportunity for users, enthusiasts, and community members to share their experiences working with Cassandra daily, hear talks and participate whether they are beginners or experts.
+ </p>
+ <p class="py-large text-center">
+ Organizing an event or want to get involved? <a href="{{{ site.url }}}/_/community.html#discussions">Get in touch with us</a>!
+ </p>
+
+ <div id="all-tiles" class="grid-list-wide list pb-large">
+ {{{page.contents}}}
+ </div>
+ </div>
+ </section>
+
+ {{> footer}}
+ </div>
+ </body>
+<script>
+jQuery(function(){
+ var cards = $('#all-tiles').find('.card');
+ var searchString = '';
+
+ // these will be external links, so comment:
+ // $(document)
+ // .on('click','.card',function(){
+ // var link = $(this).find('a').attr('href');
+ // window.open(link, '_blank');
+ // // window.location = link ;
+ // });
+
+ // $( "#search-field" ).keyup(function() {
+ // $('.card').removeClass('hidden');
+ // var val = $(this).val();
+ // val = val.toLowerCase();
+ // searchString = val;
+ // filterCards(searchString)
+ // });
+ var filterCards = function(searchString){
+ cards.each(function(){
+ var el = $(this);
+ var title = el.find('.discrete').text();
+ title = title.toLowerCase();
+ if(!title.includes(searchString)){
+ el.addClass('hidden');
+ }
+ });
+ }
+});
Review Comment:
What exactly is this trying to do that we can't just do in markup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] michaelsembwever commented on a diff in pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on code in PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#discussion_r1006884552
##########
site-content/source/modules/ROOT/pages/events.adoc:
##########
@@ -0,0 +1,277 @@
+= Events
+:page-layout: events
+:page-role: events
+
+////
+NOTES FOR CONTENT CREATORS
+- To add a new event card, copy and paste markup for one card below. Copy from '//start' to the next '//end'
+- Replace event card fields: title, date, image, short text and external link.
+////
+
+//start card
+[openblock,card shadow relative test]
+----
+[openblock,card-header]
+------
+[discrete]
+=== Cassandra Summit 2023
+[discrete]
+==== March 13-14, 2023
+------
+[openblock,card-content]
+------
+image:events/c_summit_logo.png[Cassandra Summit logo]
+
+Cassandra Summit is back! Let's meet in San Jose, California, to celebrate what we built together and share what's coming next.
+
+[openblock,card-btn card-btn--events]
+--------
+[.btn.btn--alt]
+https://events.linuxfoundation.org/cassandra-summit/[Go to event,window=_blank]
Review Comment:
this is ASF-approved external website. (that it's on LF does not matter.)
otherwise, external/vendor links should be new target, and no favouritism shown.
no objections to what is done here. good and important question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] ErickRamirezAU commented on pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
ErickRamirezAU commented on PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#issuecomment-1294660616
Sorry I couldn't fix @hemidactylus 's PR so I've pushed the commits to a new PR instead -- #188 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] hemidactylus commented on pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
hemidactylus commented on PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#issuecomment-1289075280
> @hemidactylus sorry, I just realized it's a separate link. That links to the Apache criteria for use of trademark, right? Is that temporary until we have something specific for the Cassandra PMC approval?
Ahah, the fact that both pages are `events.html` did not help, sorry about that :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] hemidactylus commented on pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
hemidactylus commented on PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#issuecomment-1292694095
I completed a redesign of the page after discussions with @ErickRamirezAU .
Now the cards are bigger and are arranged at most two per row, with a nice square image in them. Their internal spacings, etc are revised accordingly.
There is a new blurb about Cassandra Days being a community event and that contributions are welcome, from anyone, in helping run them around the world.
There is a banner on the top of the page about the Summit 2023.
The mouse pointer is back to the 'default' when hovering on the card.
This is, to me, a viable proposal. (I hereby remove the wip status from this PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] dchenbecker commented on a diff in pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
dchenbecker commented on code in PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#discussion_r1007467087
##########
site-ui/src/layouts/events.hbs:
##########
@@ -0,0 +1,73 @@
+<!DOCTYPE html>
+<html lang="en">
+ <head>
+{{> head-first}}
+ <title>Apache Cassandra{{#with site.title}} | {{this}}{{/with}}</title>
+ {{#with (canonical-url)}}
+ <link rel="canonical" href="{{this}}">
+ <link href="https://fonts.googleapis.com/css2?family=Open+Sans:ital,wght@0,400;0,700;1,400&family=Red+Hat+Display:ital,wght@0,400;0,500;0,700;1,400;1,500&display=swap" rel="stylesheet">
+ {{/with}}
+{{> head-last}}
+ <script defer src="https://cdnjs.cloudflare.com/ajax/libs/list.js/1.0.2/list.min.js"></script>
+ </head>
+ <body class="{{page.layout}}">
+ <div class="container mx-auto relative">
+ {{> header }}
+ <div class="hero hero--home grad">
+ <div class="eye"></div>
+ <div id="home-content" class="text-center flex flex-center flex-column relative z2 ma-xlarge">
+ <h1>{{ page.title }}</h1>
+ </div>
+ </div>
+ <section id="events-main" class="arrow py-large">
+ <div class="inner">
+ <p class="text-center"><a href="https://events.linuxfoundation.org/cassandra-summit" target="_blank"><img src="{{{uiRootPath}}}/img/summit-2023-1296x512.png" alt="Cassandra Summit 2023" class="events-banner"/></a></p>
+ <p class="py-large text-center">
+ Cassandra events bring the community together. Everyone (whether they are an individual user, contributor, or company) is welcome to attend and help organize these events. They are an opportunity for users, enthusiasts, and community members to share their experiences working with Cassandra daily, hear talks and participate whether they are beginners or experts.
+ </p>
+ <p class="py-large text-center">
+ Organizing an event or want to get involved? <a href="{{{ site.url }}}/_/community.html#discussions">Get in touch with us</a>!
+ </p>
+
+ <div id="all-tiles" class="grid-list-wide list pb-large">
+ {{{page.contents}}}
+ </div>
+ </div>
+ </section>
+
+ {{> footer}}
+ </div>
+ </body>
+<script>
+jQuery(function(){
+ var cards = $('#all-tiles').find('.card');
+ var searchString = '';
+
+ // these will be external links, so comment:
+ // $(document)
+ // .on('click','.card',function(){
+ // var link = $(this).find('a').attr('href');
+ // window.open(link, '_blank');
+ // // window.location = link ;
+ // });
+
+ // $( "#search-field" ).keyup(function() {
+ // $('.card').removeClass('hidden');
+ // var val = $(this).val();
+ // val = val.toLowerCase();
+ // searchString = val;
+ // filterCards(searchString)
+ // });
+ var filterCards = function(searchString){
+ cards.each(function(){
+ var el = $(this);
+ var title = el.find('.discrete').text();
+ title = title.toLowerCase();
+ if(!title.includes(searchString)){
+ el.addClass('hidden');
+ }
+ });
+ }
+});
Review Comment:
> @dchenbecker we were just trying to do the path of least resistance by replicating what the other pages already have because of the urgency of getting the page up. 🙂
Fair enough :) We might consider putting this into a common doc down the road and just include it instead of copying it, but that shouldn't block this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] josh-mckenzie commented on a diff in pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
josh-mckenzie commented on code in PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#discussion_r1007053599
##########
site-content/source/modules/ROOT/pages/events.adoc:
##########
@@ -0,0 +1,277 @@
+= Events
+:page-layout: events
+:page-role: events
+
+////
+NOTES FOR CONTENT CREATORS
+- To add a new event card, copy and paste markup for one card below. Copy from '//start' to the next '//end'
+- Replace event card fields: title, date, image, short text and external link.
+////
+
+//start card
+[openblock,card shadow relative test]
+----
+[openblock,card-header]
+------
+[discrete]
+=== Cassandra Summit 2023
+[discrete]
+==== March 13-14, 2023
+------
+[openblock,card-content]
+------
+image:events/c_summit_logo.png[Cassandra Summit logo]
+
+Cassandra Summit is back! Let's meet in San Jose, California, to celebrate what we built together and share what's coming next.
+
+[openblock,card-btn card-btn--events]
+--------
+[.btn.btn--alt]
+https://events.linuxfoundation.org/cassandra-summit/[Go to event,window=_blank]
Review Comment:
👍 Makes complete sense to me. What triggered the thought was actually a completely different domain that's regulated by a ratings board etc, so quite different context. But figured I'd check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] michaelsembwever commented on pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#issuecomment-1288920758
**Everyone** is intending this to (and knows that it must be) be fair and open to all that wish to organise and sponsor community events.
fyi @smiklosovic , @Claudenw, @dchenbecker (spread the word)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] ErickRamirezAU commented on a diff in pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
ErickRamirezAU commented on code in PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#discussion_r1007465583
##########
site-ui/src/layouts/events.hbs:
##########
@@ -0,0 +1,73 @@
+<!DOCTYPE html>
+<html lang="en">
+ <head>
+{{> head-first}}
+ <title>Apache Cassandra{{#with site.title}} | {{this}}{{/with}}</title>
+ {{#with (canonical-url)}}
+ <link rel="canonical" href="{{this}}">
+ <link href="https://fonts.googleapis.com/css2?family=Open+Sans:ital,wght@0,400;0,700;1,400&family=Red+Hat+Display:ital,wght@0,400;0,500;0,700;1,400;1,500&display=swap" rel="stylesheet">
+ {{/with}}
+{{> head-last}}
+ <script defer src="https://cdnjs.cloudflare.com/ajax/libs/list.js/1.0.2/list.min.js"></script>
+ </head>
+ <body class="{{page.layout}}">
+ <div class="container mx-auto relative">
+ {{> header }}
+ <div class="hero hero--home grad">
+ <div class="eye"></div>
+ <div id="home-content" class="text-center flex flex-center flex-column relative z2 ma-xlarge">
+ <h1>{{ page.title }}</h1>
+ </div>
+ </div>
+ <section id="events-main" class="arrow py-large">
+ <div class="inner">
+ <p class="text-center"><a href="https://events.linuxfoundation.org/cassandra-summit" target="_blank"><img src="{{{uiRootPath}}}/img/summit-2023-1296x512.png" alt="Cassandra Summit 2023" class="events-banner"/></a></p>
+ <p class="py-large text-center">
+ Cassandra events bring the community together. Everyone (whether they are an individual user, contributor, or company) is welcome to attend and help organize these events. They are an opportunity for users, enthusiasts, and community members to share their experiences working with Cassandra daily, hear talks and participate whether they are beginners or experts.
+ </p>
+ <p class="py-large text-center">
+ Organizing an event or want to get involved? <a href="{{{ site.url }}}/_/community.html#discussions">Get in touch with us</a>!
+ </p>
+
+ <div id="all-tiles" class="grid-list-wide list pb-large">
+ {{{page.contents}}}
+ </div>
+ </div>
+ </section>
+
+ {{> footer}}
+ </div>
+ </body>
+<script>
+jQuery(function(){
+ var cards = $('#all-tiles').find('.card');
+ var searchString = '';
+
+ // these will be external links, so comment:
+ // $(document)
+ // .on('click','.card',function(){
+ // var link = $(this).find('a').attr('href');
+ // window.open(link, '_blank');
+ // // window.location = link ;
+ // });
+
+ // $( "#search-field" ).keyup(function() {
+ // $('.card').removeClass('hidden');
+ // var val = $(this).val();
+ // val = val.toLowerCase();
+ // searchString = val;
+ // filterCards(searchString)
+ // });
+ var filterCards = function(searchString){
+ cards.each(function(){
+ var el = $(this);
+ var title = el.find('.discrete').text();
+ title = title.toLowerCase();
+ if(!title.includes(searchString)){
+ el.addClass('hidden');
+ }
+ });
+ }
+});
Review Comment:
@dchenbecker we were just trying to do the path of least resistance by replicating what the other pages already have because of the urgency of getting the page up. 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] josh-mckenzie commented on a diff in pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
josh-mckenzie commented on code in PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#discussion_r1006801469
##########
site-content/source/modules/ROOT/pages/blog/Apache-Cassandra-4.1-Features-Guardrails-Framework.adoc:
##########
@@ -70,7 +70,7 @@ Warnings :
Guardrail tables violated: Creating table t6, current number of tables 6 exceeds warning threshold of 5.
```
-However, if the hard limit is reached, the user operation will be aborted with a `GuardrailViolatedException`, preventing the potentially harmful operation from happening. Continuing with the previous example, if we have a hard limit of ten tables (`tables_warn_threshold: 10`) and we try to create an eleventh table, we will see an error and the eleventh table won’t be created:
+However, if the hard limit is reached, the user operation will be aborted with a `GuardrailViolatedException`, preventing the potentially harmful operation from happening. Continuing with the previous example, if we have a hard limit of ten tables (`tables_fail_threshold: 10`) and we try to create an eleventh table, we will see an error and the eleventh table won’t be created:
Review Comment:
Do we regularly sneak things in to PR's for website changes? For the record: definitely not against this. Just want to double check this isn't accidentally flying under the radar here and colliding with other work in flight and/or accidentally pulled over from a larger change.
##########
site-content/source/modules/ROOT/pages/download.adoc:
##########
@@ -18,14 +18,14 @@
[discrete]
==== Download the latest Apache Cassandra 4.0 GA release:
[discrete]
-====== Released on 2022-08-25
+====== Released on 2022-10-23
Review Comment:
How do we normally update versions on the site? Is this something we just do adhoc when we realize they're stale, or perhaps something we can integrate into our release manager pipeline and collab w/Mick / release managers on?
##########
site-content/source/modules/ROOT/pages/events.adoc:
##########
@@ -0,0 +1,277 @@
+= Events
+:page-layout: events
+:page-role: events
+
+////
+NOTES FOR CONTENT CREATORS
+- To add a new event card, copy and paste markup for one card below. Copy from '//start' to the next '//end'
+- Replace event card fields: title, date, image, short text and external link.
+////
+
+//start card
+[openblock,card shadow relative test]
+----
+[openblock,card-header]
+------
+[discrete]
+=== Cassandra Summit 2023
+[discrete]
+==== March 13-14, 2023
+------
+[openblock,card-content]
+------
+image:events/c_summit_logo.png[Cassandra Summit logo]
+
+Cassandra Summit is back! Let's meet in San Jose, California, to celebrate what we built together and share what's coming next.
+
+[openblock,card-btn card-btn--events]
+--------
+[.btn.btn--alt]
+https://events.linuxfoundation.org/cassandra-summit/[Go to event,window=_blank]
Review Comment:
When we link to external non-ASF hosted sites, is there any need for a notification that you're leaving the ASF space and going to a particular vendor or other foundation's properties / sites? Genuinely asking here as I don't know and want to make sure we grease the skids on this as much as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] michaelsembwever commented on a diff in pull request #185: A dedicated "events" section on Cassandra website
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on code in PR #185:
URL: https://github.com/apache/cassandra-website/pull/185#discussion_r1007243606
##########
site-content/source/modules/ROOT/pages/download.adoc:
##########
@@ -18,14 +18,14 @@
[discrete]
==== Download the latest Apache Cassandra 4.0 GA release:
[discrete]
-====== Released on 2022-08-25
+====== Released on 2022-10-23
Review Comment:
I don't know why this PR is updating those dates, it shouldn't be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org