You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/03/25 23:23:03 UTC
[GitHub] [logging-log4j2] uschindler opened a new pull request #355: LOG4J2-2761: Fix FileUtils#fileFromUri to works correctly with Securi…
uschindler opened a new pull request #355: LOG4J2-2761: Fix FileUtils#fileFromUri to works correctly with Securi…
URL: https://github.com/apache/logging-log4j2/pull/355
…tyManager and also fix URI parsing to behave sane with standards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] uschindler edited a comment on issue #355: LOG4J2-2761: Fix FileUtils#fileFromUri to works correctly with Securi…
Posted by GitBox <gi...@apache.org>.
uschindler edited a comment on issue #355: LOG4J2-2761: Fix FileUtils#fileFromUri to works correctly with Securi…
URL: https://github.com/apache/logging-log4j2/pull/355#issuecomment-604324659
I figured out where the issue is: If the file does not exist, `fileFromUri(URI)` returns null. The previous code worked and just returned the relative file name. The problem was a bit of fall-through logic in old code that was not obvious. New code is now much cleaner and easier to understand. Should be fixed now. Running tests and will push afterwards.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] uschindler commented on issue #355: LOG4J2-2761: Fix FileUtils#fileFromUri to works correctly with Securi…
Posted by GitBox <gi...@apache.org>.
uschindler commented on issue #355: LOG4J2-2761: Fix FileUtils#fileFromUri to works correctly with Securi…
URL: https://github.com/apache/logging-log4j2/pull/355#issuecomment-604301231
This did not happen locally:
```
[ERROR] Failures:
[ERROR] FileOutputTest.testConfig:46 Status output file does not exist
Expected: file exists is <true>
but: file exists was <false>
[ERROR] TimeFilterTest.testTime:193 expected same:<NEUTRAL> was not:<DENY>
````
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] uschindler commented on issue #355: LOG4J2-2761: Fix FileUtils#fileFromUri to works correctly with Securi…
Posted by GitBox <gi...@apache.org>.
uschindler commented on issue #355: LOG4J2-2761: Fix FileUtils#fileFromUri to works correctly with Securi…
URL: https://github.com/apache/logging-log4j2/pull/355#issuecomment-604324659
I figured out where the issue is: If the file does not exist, `fileFromUri(URI)` returns null. The previous code worked. The problem was a bit of fall-through logic. Should be fixed now. Running tests and will push afterwards.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] rgoers merged pull request #355: LOG4J2-2761: Fix FileUtils#fileFromUri to works correctly with Securi…
Posted by GitBox <gi...@apache.org>.
rgoers merged pull request #355: LOG4J2-2761: Fix FileUtils#fileFromUri to works correctly with Securi…
URL: https://github.com/apache/logging-log4j2/pull/355
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services