You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by fe...@apache.org on 2017/03/26 19:34:40 UTC
zeppelin git commit: [ZEPPELIN-2211] Too many WARN logs: "Couldn't
get interpreter editor setting"
Repository: zeppelin
Updated Branches:
refs/heads/master 15641d098 -> 78e2e912b
[ZEPPELIN-2211] Too many WARN logs: "Couldn't get interpreter editor setting"
### What is this PR for?
every time we insert invalid backend magic (e.g `sparc`), `InterpreterSettingManager` throws WARN log.
I changed the log level to debug because
- WARN level should not be used for this kind of situation.
- This log doesn't provide any useful information for user. So info level is not proper as well.
I attached a screenshot.
### What type of PR is it?
[Improvement]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2211](https://issues.apache.org/jira/browse/ZEPPELIN-2211)
### How should this be tested?
- Insert invalid magic in your paragraph. For example `sparc` or `marcdown`
### Screenshots (if appropriate)
![interpreter_setting_manager](https://cloud.githubusercontent.com/assets/4968473/24235266/cbecbbf4-0fdf-11e7-9fcc-f1a95a5e82ab.gif)
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
Author: 1ambda <1a...@gmail.com>
Closes #2179 from 1ambda/ZEPPELIN-2211/change-log-level-ISM-NPE and squashes the following commits:
e333c1c [1ambda] fix: Change log level to debug from warn
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/78e2e912
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/78e2e912
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/78e2e912
Branch: refs/heads/master
Commit: 78e2e912b6f9014e9a83c929cde339dcb8459bdc
Parents: 15641d0
Author: 1ambda <1a...@gmail.com>
Authored: Thu Mar 23 15:39:39 2017 +0900
Committer: Felix Cheung <fe...@apache.org>
Committed: Sun Mar 26 12:34:37 2017 -0700
----------------------------------------------------------------------
.../apache/zeppelin/interpreter/InterpreterSettingManager.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/78e2e912/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java
index 32db89b..f031591 100644
--- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java
+++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java
@@ -514,7 +514,8 @@ public class InterpreterSettingManager {
}
}
} catch (NullPointerException e) {
- logger.warn("Couldn't get interpreter editor setting");
+ // Use `debug` level because this log occurs frequently
+ logger.debug("Couldn't get interpreter editor setting");
}
return editor;
}