You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by carl34 <gi...@git.apache.org> on 2017/05/22 23:12:29 UTC
[GitHub] storm pull request #2133: Add the option to set client.id to storm-kafka, ST...
GitHub user carl34 opened a pull request:
https://github.com/apache/storm/pull/2133
Add the option to set client.id to storm-kafka, STORM-2524
Add the ability to set the Kafka client.id property to storm-kafka and storm-kafka-client (https://issues.apache.org/jira/browse/STORM-2524).
storm-kafka example:
```
SpoutConfig spoutConfig = new SpoutConfig(
brokers,
topicConfs.topic,
+ "client_id-" + confs.consumerGroupId + "-" + topicConfs.topic,
"/consumers",
confs.consumerGroupId + "-" + topicConfs.topic
);
```
storm-kafka-client example:
```
KafkaSpoutConfig<String,String> kafkaSpoutConfig = KafkaSpoutConfig.builder(KAFKA_LOCAL_BROKER, TOPIC)
.setGroupId(confs.consumerGroupId + "-" + topicConfs.topic)
+ .setClientId("client_id-" + confs.consumerGroupId + "-" + topicConfs.topic)
.build();
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/carl34/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2133.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2133
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2133: Add the option to set client.id to storm-kafka, STORM-252...
Posted by carl34 <gi...@git.apache.org>.
Github user carl34 commented on the issue:
https://github.com/apache/storm/pull/2133
@revans2, please let me know if I need to make any more adjustments for this to be merged in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2133: Add the option to set client.id to storm-kafka, ST...
Posted by carl34 <gi...@git.apache.org>.
Github user carl34 closed the pull request at:
https://github.com/apache/storm/pull/2133
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2133: Add the option to set client.id to storm-kafka, STORM-252...
Posted by carl34 <gi...@git.apache.org>.
Github user carl34 commented on the issue:
https://github.com/apache/storm/pull/2133
See original PR, https://github.com/apache/storm/pull/2126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2133: Add the option to set client.id to storm-kafka, STORM-252...
Posted by carl34 <gi...@git.apache.org>.
Github user carl34 commented on the issue:
https://github.com/apache/storm/pull/2133
See https://github.com/apache/storm/pull/2126 for review details, re-creating second time (first attempt was https://github.com/apache/storm/pull/2132) to resolve CHANGELOG.md conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---