You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/06/12 17:41:23 UTC
[Impala-ASF-CR] IMPALA-8650: Docker build should not depend on test config
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13597
Change subject: IMPALA-8650: Docker build should not depend on test config
......................................................................
IMPALA-8650: Docker build should not depend on test config
Change-Id: Iaa70864f5d047d1ff5f21e69d8f6358306424c0b
---
M bin/create-test-configuration.sh
M docker/CMakeLists.txt
M fe/CMakeLists.txt
3 files changed, 1 insertion(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/13597/1
--
To view, visit http://gerrit.cloudera.org:8080/13597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa70864f5d047d1ff5f21e69d8f6358306424c0b
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8650: Docker build should not depend on test config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13597 )
Change subject: IMPALA-8650: Docker build should not depend on test config
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4467/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa70864f5d047d1ff5f21e69d8f6358306424c0b
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 06:35:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8650: Docker build should not depend on test config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13597 )
Change subject: IMPALA-8650: Docker build should not depend on test config
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa70864f5d047d1ff5f21e69d8f6358306424c0b
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 23:15:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8650: Docker build should not depend on test config
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13597 )
Change subject: IMPALA-8650: Docker build should not depend on test config
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13597/2/fe/CMakeLists.txt
File fe/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/13597/2/fe/CMakeLists.txt@23
PS2, Line 23: test-configuration
It looks like we don't use this target. We could remove it. I'm ok with keeping it, if we think a "make test-configuration" command is useful.
--
To view, visit http://gerrit.cloudera.org:8080/13597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa70864f5d047d1ff5f21e69d8f6358306424c0b
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 00:41:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8650: Docker build should not depend on test config
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13597 )
Change subject: IMPALA-8650: Docker build should not depend on test config
......................................................................
IMPALA-8650: Docker build should not depend on test config
Change-Id: Iaa70864f5d047d1ff5f21e69d8f6358306424c0b
Reviewed-on: http://gerrit.cloudera.org:8080/13597
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M bin/create-test-configuration.sh
M docker/CMakeLists.txt
M fe/CMakeLists.txt
3 files changed, 0 insertions(+), 23 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Joe McDonnell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa70864f5d047d1ff5f21e69d8f6358306424c0b
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8650: Docker build should not depend on test config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13597 )
Change subject: IMPALA-8650: Docker build should not depend on test config
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3579/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa70864f5d047d1ff5f21e69d8f6358306424c0b
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 18:22:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8650: Docker build should not depend on test config
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13597 )
Change subject: IMPALA-8650: Docker build should not depend on test config
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13597/2/fe/CMakeLists.txt
File fe/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/13597/2/fe/CMakeLists.txt@23
PS2, Line 23: test-configuration
> It looks like we don't use this target. We could remove it. I'm ok with kee
Probably not useful enough to keep it around :)
I kinda think on principle that more of the dependencies for the test infra should be in CMake and less should be in shell scripts, but I don't think having a random unused target helps that much.
--
To view, visit http://gerrit.cloudera.org:8080/13597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa70864f5d047d1ff5f21e69d8f6358306424c0b
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 06:35:01 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8650: Docker build should not depend on test config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13597 )
Change subject: IMPALA-8650: Docker build should not depend on test config
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa70864f5d047d1ff5f21e69d8f6358306424c0b
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 12:07:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8650: Docker build should not depend on test config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13597 )
Change subject: IMPALA-8650: Docker build should not depend on test config
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4456/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa70864f5d047d1ff5f21e69d8f6358306424c0b
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 17:44:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8650: Docker build should not depend on test config
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13597 )
Change subject: IMPALA-8650: Docker build should not depend on test config
......................................................................
Patch Set 4: Code-Review+2
Great, looks good.
--
To view, visit http://gerrit.cloudera.org:8080/13597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa70864f5d047d1ff5f21e69d8f6358306424c0b
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 15:08:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8650: Docker build should not depend on test config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13597 )
Change subject: IMPALA-8650: Docker build should not depend on test config
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3594/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa70864f5d047d1ff5f21e69d8f6358306424c0b
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 07:18:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8650: Docker build should not depend on test config
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13597
to look at the new patch set (#3).
Change subject: IMPALA-8650: Docker build should not depend on test config
......................................................................
IMPALA-8650: Docker build should not depend on test config
Change-Id: Iaa70864f5d047d1ff5f21e69d8f6358306424c0b
---
M bin/create-test-configuration.sh
M docker/CMakeLists.txt
M fe/CMakeLists.txt
3 files changed, 0 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/13597/3
--
To view, visit http://gerrit.cloudera.org:8080/13597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa70864f5d047d1ff5f21e69d8f6358306424c0b
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>