You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/27 03:43:08 UTC

[GitHub] [spark] c21 commented on pull request #29547: [SPARK-32705][SQL] Fix serialization issue for EmptyHashedRelation

c21 commented on pull request #29547:
URL: https://github.com/apache/spark/pull/29547#issuecomment-681328705


   > I considered adding a UT for this issue, too. But it's wrong usage about using scala object with Externalizable interface, since it is removed, I think scala case object itself can guarantee the serialization; besides, I've run the entire TPCDS just to make sure the E2E coverage, I think it should be enough, ^_^
   
   @leanken - cool, thanks for testing this end to end. :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org