You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/02/22 06:07:29 UTC
Review Request 56915: AMBARI-20107.Action node shows unsupported
properties even though there are none in workflow manager.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56915/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-20107
https://issues.apache.org/jira/browse/AMBARI-20107
Repository: ambari
Description
-------
The issue is because the jsog object id is appended to the xml. Fixed by excluding jsog object id in the unsupported properties.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js d09de7d
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs fae2d3d
Diff: https://reviews.apache.org/r/56915/diff/
Testing
-------
Manual Testing
Thanks,
Padma Priya N
Re: Review Request 56915: AMBARI-20107.Action node shows unsupported
properties even though there are none in workflow manager.
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56915/#review166338
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On Feb. 22, 2017, 6:32 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56915/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 6:32 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20107
> https://issues.apache.org/jira/browse/AMBARI-20107
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The issue is because the jsog object id is appended to the xml. Fixed by excluding jsog object id in the unsupported properties.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js d09de7d
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs fae2d3d
>
> Diff: https://reviews.apache.org/r/56915/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 56915: AMBARI-20107.Action node shows unsupported
properties even though there are none in workflow manager.
Posted by belliraj hb <be...@gmail.com>.
> On Feb. 22, 2017, 7:20 a.m., Nitiraj Rathore wrote:
> > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js, line 72
> > <https://reviews.apache.org/r/56915/diff/2/?file=1642201#file1642201line72>
> >
> > It looks like this might break if some more internal keys are added to ember objects in later versions.
> > Can you rely on something like : JSON.parse(JSON.stringify(unsupportedProperties))
> > to get plain js object.
This deletes only one property __jsogObjectId which is added automatically by JSOG library which is the only thing we want to remove. it doesnt affect other internal keys added to ember object.
- belliraj
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56915/#review166327
-----------------------------------------------------------
On Feb. 22, 2017, 6:32 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56915/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 6:32 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20107
> https://issues.apache.org/jira/browse/AMBARI-20107
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The issue is because the jsog object id is appended to the xml. Fixed by excluding jsog object id in the unsupported properties.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js d09de7d
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs fae2d3d
>
> Diff: https://reviews.apache.org/r/56915/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 56915: AMBARI-20107.Action node shows unsupported
properties even though there are none in workflow manager.
Posted by belliraj hb <be...@gmail.com>.
> On Feb. 22, 2017, 7:20 a.m., Nitiraj Rathore wrote:
> > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js, line 72
> > <https://reviews.apache.org/r/56915/diff/2/?file=1642201#file1642201line72>
> >
> > It looks like this might break if some more internal keys are added to ember objects in later versions.
> > Can you rely on something like : JSON.parse(JSON.stringify(unsupportedProperties))
> > to get plain js object.
>
> belliraj hb wrote:
> This deletes only one property __jsogObjectId which is added automatically by JSOG library which is the only thing we want to remove. it doesnt affect other internal keys added to ember object.
Dint want to use Json with the code as the domain model of wofklow will have cyclic dependency. hence using JSOG notation. __jsogObjectID is a documented field in the JSOG library. Hence we are removing JSOG added properties.
- belliraj
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56915/#review166327
-----------------------------------------------------------
On Feb. 22, 2017, 6:32 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56915/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 6:32 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20107
> https://issues.apache.org/jira/browse/AMBARI-20107
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The issue is because the jsog object id is appended to the xml. Fixed by excluding jsog object id in the unsupported properties.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js d09de7d
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs fae2d3d
>
> Diff: https://reviews.apache.org/r/56915/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 56915: AMBARI-20107.Action node shows unsupported
properties even though there are none in workflow manager.
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56915/#review166327
-----------------------------------------------------------
contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js (line 72)
<https://reviews.apache.org/r/56915/#comment238276>
It looks like this might break if some more internal keys are added to ember objects in later versions.
Can you rely on something like : JSON.parse(JSON.stringify(unsupportedProperties))
to get plain js object.
- Nitiraj Rathore
On Feb. 22, 2017, 6:32 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56915/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 6:32 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20107
> https://issues.apache.org/jira/browse/AMBARI-20107
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The issue is because the jsog object id is appended to the xml. Fixed by excluding jsog object id in the unsupported properties.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js d09de7d
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs fae2d3d
>
> Diff: https://reviews.apache.org/r/56915/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 56915: AMBARI-20107.Action node shows unsupported
properties even though there are none in workflow manager.
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56915/#review166478
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 22, 2017, 6:32 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56915/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 6:32 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20107
> https://issues.apache.org/jira/browse/AMBARI-20107
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The issue is because the jsog object id is appended to the xml. Fixed by excluding jsog object id in the unsupported properties.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js d09de7d
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs fae2d3d
>
> Diff: https://reviews.apache.org/r/56915/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 56915: AMBARI-20107.Action node shows unsupported
properties even though there are none in workflow manager.
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56915/#review166355
-----------------------------------------------------------
Ship it!
Ship It!
- Nitiraj Rathore
On Feb. 22, 2017, 6:32 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56915/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 6:32 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20107
> https://issues.apache.org/jira/browse/AMBARI-20107
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The issue is because the jsog object id is appended to the xml. Fixed by excluding jsog object id in the unsupported properties.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js d09de7d
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs fae2d3d
>
> Diff: https://reviews.apache.org/r/56915/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 56915: AMBARI-20107.Action node shows unsupported
properties even though there are none in workflow manager.
Posted by Padma Priya N <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56915/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 6:32 a.m.)
Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-20107
https://issues.apache.org/jira/browse/AMBARI-20107
Repository: ambari
Description
-------
The issue is because the jsog object id is appended to the xml. Fixed by excluding jsog object id in the unsupported properties.
Diffs (updated)
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js d09de7d
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs fae2d3d
Diff: https://reviews.apache.org/r/56915/diff/
Testing
-------
Manual Testing
Thanks,
Padma Priya N