You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ignite.apache.org by "Ivan Bessonov (Jira)" <ji...@apache.org> on 2021/10/01 10:59:00 UTC

[jira] [Commented] (IGNITE-15661) Migrate SystemPropertiesExtension to JUnit 5

    [ https://issues.apache.org/jira/browse/IGNITE-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423233#comment-17423233 ] 

Ivan Bessonov commented on IGNITE-15661:
----------------------------------------

Looks good to me, thank you for the improvement!

> Migrate SystemPropertiesExtension to JUnit 5
> --------------------------------------------
>
>                 Key: IGNITE-15661
>                 URL: https://issues.apache.org/jira/browse/IGNITE-15661
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Aleksandr Polovtcev
>            Assignee: Aleksandr Polovtcev
>            Priority: Trivial
>              Labels: ignite-3
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {{SystemPropertiesExtension}} was ported from Ignite 2 as a JUnit extension, but it wasn't done fully correctly: for example, it uses fields to handle its state, which is not the recommended way, it should use a {{Store}} instead. We should review its implementation and fix such things.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)