You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Aravindan Vijayan <av...@hortonworks.com> on 2017/02/08 17:32:45 UTC

Review Request 56453: AMBARI-19758 : Post Ambari upgrade AMS config properties changes are marking HDFS/YARN/Hive/HBase with restart required

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56453/
-----------------------------------------------------------

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-19758
    https://issues.apache.org/jira/browse/AMBARI-19758


Repository: ambari


Description
-------

Deploy Ambari-2.4 and upgrade to Ambari-2.5. Noticed that all core services are marked with restart required.

FIX
Removed hadoop-metrics2.properties.xml from common-services and moved it to the stack.


Diffs
-----

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml 6b45e84 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml b1db696 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 642b63e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py cf958f0 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEHDFS/metainfo.xml 14f15fc 

Diff: https://reviews.apache.org/r/56453/diff/


Testing
-------

Manually tested Ambari upgrade from 2.4.0 to 2.5.0.


Thanks,

Aravindan Vijayan


Re: Review Request 56453: AMBARI-19758 : Post Ambari upgrade AMS config properties changes are marking HDFS/YARN/Hive/HBase with restart required

Posted by Aravindan Vijayan <av...@hortonworks.com>.

> On Feb. 9, 2017, 7:20 p.m., Alejandro Fernandez wrote:
> >

The changes are already present in HDFS 3.0.0.3.0.


- Aravindan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56453/#review164983
-----------------------------------------------------------


On Feb. 9, 2017, 1:29 a.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56453/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 1:29 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19758
>     https://issues.apache.org/jira/browse/AMBARI-19758
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Deploy Ambari-2.4 and upgrade to Ambari-2.5. Noticed that all core services are marked with restart required.
> 
> FIX
> Removed hadoop-metrics2.properties.xml from common-services and moved it to the stack.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml 6b45e84 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml b1db696 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 642b63e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py cf958f0 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/metainfo.xml 1fc7f51 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEHDFS/metainfo.xml 14f15fc 
> 
> Diff: https://reviews.apache.org/r/56453/diff/
> 
> 
> Testing
> -------
> 
> Manually tested Ambari upgrade from 2.4.0 to 2.5.0.
> Manually tested HDP upgrade from 2.5.3 to 2.6
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>


Re: Review Request 56453: AMBARI-19758 : Post Ambari upgrade AMS config properties changes are marking HDFS/YARN/Hive/HBase with restart required

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56453/#review164983
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
<https://reviews.apache.org/r/56453/#comment236818>

    Is this change also needed in HDFS 3.0.0.3.0?



ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py (line 49)
<https://reviews.apache.org/r/56453/#comment236819>

    Same comment for HDP 3.0 stack.


- Alejandro Fernandez


On Feb. 9, 2017, 1:29 a.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56453/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 1:29 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19758
>     https://issues.apache.org/jira/browse/AMBARI-19758
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Deploy Ambari-2.4 and upgrade to Ambari-2.5. Noticed that all core services are marked with restart required.
> 
> FIX
> Removed hadoop-metrics2.properties.xml from common-services and moved it to the stack.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml 6b45e84 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml b1db696 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 642b63e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py cf958f0 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/metainfo.xml 1fc7f51 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEHDFS/metainfo.xml 14f15fc 
> 
> Diff: https://reviews.apache.org/r/56453/diff/
> 
> 
> Testing
> -------
> 
> Manually tested Ambari upgrade from 2.4.0 to 2.5.0.
> Manually tested HDP upgrade from 2.5.3 to 2.6
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>


Re: Review Request 56453: AMBARI-19758 : Post Ambari upgrade AMS config properties changes are marking HDFS/YARN/Hive/HBase with restart required

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56453/#review164841
-----------------------------------------------------------


Ship it!




Ship It!

- Sid Wagle


On Feb. 9, 2017, 1:29 a.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56453/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 1:29 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19758
>     https://issues.apache.org/jira/browse/AMBARI-19758
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Deploy Ambari-2.4 and upgrade to Ambari-2.5. Noticed that all core services are marked with restart required.
> 
> FIX
> Removed hadoop-metrics2.properties.xml from common-services and moved it to the stack.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml 6b45e84 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml b1db696 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 642b63e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py cf958f0 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/metainfo.xml 1fc7f51 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEHDFS/metainfo.xml 14f15fc 
> 
> Diff: https://reviews.apache.org/r/56453/diff/
> 
> 
> Testing
> -------
> 
> Manually tested Ambari upgrade from 2.4.0 to 2.5.0.
> Manually tested HDP upgrade from 2.5.3 to 2.6
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>


Re: Review Request 56453: AMBARI-19758 : Post Ambari upgrade AMS config properties changes are marking HDFS/YARN/Hive/HBase with restart required

Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56453/
-----------------------------------------------------------

(Updated Feb. 9, 2017, 1:29 a.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-19758
    https://issues.apache.org/jira/browse/AMBARI-19758


Repository: ambari


Description
-------

Deploy Ambari-2.4 and upgrade to Ambari-2.5. Noticed that all core services are marked with restart required.

FIX
Removed hadoop-metrics2.properties.xml from common-services and moved it to the stack.


Diffs
-----

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml 6b45e84 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml b1db696 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 642b63e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py cf958f0 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/metainfo.xml 1fc7f51 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEHDFS/metainfo.xml 14f15fc 

Diff: https://reviews.apache.org/r/56453/diff/


Testing (updated)
-------

Manually tested Ambari upgrade from 2.4.0 to 2.5.0.
Manually tested HDP upgrade from 2.5.3 to 2.6


Thanks,

Aravindan Vijayan


Re: Review Request 56453: AMBARI-19758 : Post Ambari upgrade AMS config properties changes are marking HDFS/YARN/Hive/HBase with restart required

Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56453/
-----------------------------------------------------------

(Updated Feb. 9, 2017, 1:27 a.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Changes
-------

Added hadoop-metrics2.properties config type as a config-dependency to HDFS in stack so that Ambari triggers restart needed for HDFS whenever a change is made to that template.


Bugs: AMBARI-19758
    https://issues.apache.org/jira/browse/AMBARI-19758


Repository: ambari


Description
-------

Deploy Ambari-2.4 and upgrade to Ambari-2.5. Noticed that all core services are marked with restart required.

FIX
Removed hadoop-metrics2.properties.xml from common-services and moved it to the stack.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml 6b45e84 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml b1db696 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 642b63e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py cf958f0 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/metainfo.xml 1fc7f51 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEHDFS/metainfo.xml 14f15fc 

Diff: https://reviews.apache.org/r/56453/diff/


Testing
-------

Manually tested Ambari upgrade from 2.4.0 to 2.5.0.


Thanks,

Aravindan Vijayan


Re: Review Request 56453: AMBARI-19758 : Post Ambari upgrade AMS config properties changes are marking HDFS/YARN/Hive/HBase with restart required

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56453/#review164738
-----------------------------------------------------------


Ship it!




Ship It!

- Sid Wagle


On Feb. 8, 2017, 5:32 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56453/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 5:32 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19758
>     https://issues.apache.org/jira/browse/AMBARI-19758
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Deploy Ambari-2.4 and upgrade to Ambari-2.5. Noticed that all core services are marked with restart required.
> 
> FIX
> Removed hadoop-metrics2.properties.xml from common-services and moved it to the stack.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml 6b45e84 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml b1db696 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 642b63e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py cf958f0 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEHDFS/metainfo.xml 14f15fc 
> 
> Diff: https://reviews.apache.org/r/56453/diff/
> 
> 
> Testing
> -------
> 
> Manually tested Ambari upgrade from 2.4.0 to 2.5.0.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>