You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by FlorianHockmann <gi...@git.apache.org> on 2017/06/09 14:21:37 UTC

[GitHub] tinkerpop pull request #623: TINKERPOP-1552: Minor code cleanup for Gremlin....

GitHub user FlorianHockmann opened a pull request:

    https://github.com/apache/tinkerpop/pull/623

    TINKERPOP-1552: Minor code cleanup for Gremlin.Net

    https://issues.apache.org/jira/browse/TINKERPOP-1552
    
    This mainly removes explicit type castings that are now obsolete thanks to changes from the pull request #620 from @jorgebay. It also makes the Dictionary CSharpToJavaEnums in NamingConversions private to avoid direct access to it as GetEnumJavaName should be used instead.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/FlorianHockmann/tinkerpop dotnet-glv-cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/623.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #623
    
----
commit 68c5a0cbb368f18f1e8650a84eee2f56e3bc2507
Author: Florian Hockmann <fh...@florian-hockmann.de>
Date:   2017-06-09T14:14:49Z

    Minor code cleanup for Gremlin.Net
    
    This mainly removes explicit type casting that are now obsolete thanks to changes from the pull request #620. It also makes the Dictionary CSharpToJavaEnums in NamingConversions private to avoid direct access to it as GetEnumJavaName should be used instead.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #623: TINKERPOP-1552: Minor code cleanup for Gremlin.Net

Posted by jorgebay <gi...@git.apache.org>.
Github user jorgebay commented on the issue:

    https://github.com/apache/tinkerpop/pull/623
  
    lgtm! +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #623: TINKERPOP-1552: Minor code cleanup for Gremlin....

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/623


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---