[GitHub] johnyangk commented on a change in pull request #81: [NEMO-151] Add OutputWriters for additional tagged outputs

[GitBox <gi...@apache.org>]

johnyangk commented on a change in pull request #81: [NEMO-151] Add OutputWriters for additional tagged outputs
URL: https://github.com/apache/incubator-nemo/pull/81#discussion_r203941717
 
 

 ##########
 File path: compiler/optimizer/src/main/java/edu/snu/nemo/compiler/optimizer/pass/compiletime/reshaping/SailfishRelayReshapingPass.java
 ##########
 @@ -60,6 +62,21 @@ public SailfishRelayReshapingPass() {
             // before the vertex receiving shuffled data.
             final OperatorVertex iFileMergerVertex = new OperatorVertex(new RelayTransform());
             iFileMergerVertex.getExecutionProperties().put(SkipSerDesProperty.of());
+
+            // Update additional tagged output property of the source vertex if necessary.
 
 Review comment:
   @shpark Can we have an offline meeting to discuss this?
   I'd like to know if this something that a certain type of reshaping pass always has to check, and if there's a way to handle this automatically.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services