[GitHub] [beam] ibzib commented on a change in pull request #15082: [BEAM-12538] Allow PipelineOptions to be specified on command line of ExpansionService

[GitBox <gi...@apache.org>]

ibzib commented on a change in pull request #15082:
URL: https://github.com/apache/beam/pull/15082#discussion_r662504981



##########
File path: sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
##########
@@ -391,17 +410,19 @@ default InputT createInput(Pipeline p, Map<String, PCollection<?>> inputs) {
         request.getTransform().getSpec().getUrn());
     LOG.debug("Full transform: {}", request.getTransform());
     Set<String> existingTransformIds = request.getComponents().getTransformsMap().keySet();
-    Pipeline pipeline = Pipeline.create();
-    ExperimentalOptions.addExperiment(
-        pipeline.getOptions().as(ExperimentalOptions.class), "beam_fn_api");
-    // TODO(BEAM-10670): Remove this when we address performance issue.
-    ExperimentalOptions.addExperiment(
-        pipeline.getOptions().as(ExperimentalOptions.class), "use_sdf_read");
+    Pipeline pipeline = createPipeline();
+    if (!ExperimentalOptions.hasExperiment(pipelineOptions, "use_deprecated_read")) {

Review comment:
       Where are these options read? Do we test that these options are respected?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org