You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/04/12 01:59:06 UTC

[GitHub] [iotdb] mychaow opened a new pull request #2993: uncomment the less used configuration

mychaow opened a new pull request #2993:
URL: https://github.com/apache/iotdb/pull/2993


   ## Description
   
   Comment out the configuration items that are rarely used, which will be more user-friendly.
   
   ### Content1 ...
   
   ### Content2 ...
   
   ### Content3 ...
   
   <!--
   In each section, please describe design decisions made, including:
    - Choice of algorithms
    - Behavioral aspects. What configuration values are acceptable? How are corner cases and error 
       conditions handled, such as when there are insufficient resources?
    - Class organization and design (how the logic is split between classes, inheritance, composition, 
       design patterns)
    - Method organization and design (how the logic is split between methods, parameters and return types)
    - Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
   -->
   
   
   <!-- It's good to describe an alternative design (or mention an alternative name) for every design 
   (or naming) decision point and compare the alternatives with the designs that you've implemented 
   (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
   
   <!-- If there was a discussion of the design of the feature implemented in this PR elsewhere 
   (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), 
   link to that discussion from this PR description and explain what have changed in your final design 
   compared to your original proposal or the consensus version in the end of the discussion. 
   If something hasn't changed since the original discussion, you can omit a detailed discussion of 
   those aspects of the design here, perhaps apart from brief mentioning for the sake of readability 
   of this PR description. -->
   
   <!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
   
   <hr>
   
   This PR has:
   - [ ] been self-reviewed.
       - [ ] concurrent read
       - [ ] concurrent write
       - [ ] concurrent read and write 
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. 
   - [ ] added or updated version, __license__, or notice information
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious 
     for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold 
     for code coverage.
   - [ ] added integration tests.
   - [ ] been tested in a test IoTDB cluster.
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items 
   apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items 
   from the checklist above are strictly necessary, but it would be very helpful if you at least 
   self-review the PR. -->
   
   <hr>
   
   ##### Key changed/added classes (or packages if there are too many classes) in this PR
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] mychaow commented on a change in pull request #2993: uncomment the less used configuration

Posted by GitBox <gi...@apache.org>.
mychaow commented on a change in pull request #2993:
URL: https://github.com/apache/iotdb/pull/2993#discussion_r611399439



##########
File path: cluster/src/assembly/resources/conf/iotdb-cluster.properties
##########
@@ -57,117 +57,117 @@ seed_nodes=127.0.0.1:9003,127.0.0.1:9005,127.0.0.1:9007
 # compression settings for external clients, please modify 'rpc_thrift_compression_enable' in
 # 'iotdb-engine.properties'.
 # WARNING: this must be consistent across all nodes in the cluster
-rpc_thrift_compression_enable=false
+# rpc_thrift_compression_enable=false
 
 # max client connections created by thrift
 # this configuration applies separately to data/meta/client connections and thus does not control
 # the number of global connections
-max_concurrent_client_num=10000
+# max_concurrent_client_num=10000
 
 # number of replications for one partition
 default_replica_num=3
 
 # cluster name to identify different clusters
 # all node's cluster_name in one cluster are the same
-cluster_name=default
+# cluster_name=default
 
 # connection time out (ms) among raft nodes
-connection_timeout_ms=20000
+# connection_timeout_ms=20000
 
 # write operation timeout threshold (ms), this is only for internal communications,
 # not for the whole operation.
-write_operation_timeout_ms=30000
+# write_operation_timeout_ms=30000
 
 # read operation timeout threshold (ms), this is only for internal communications,
 # not for the whole operation.
-read_operation_timeout_ms=30000
+# read_operation_timeout_ms=30000
 
 # catch up timeout threshold (ms), this is used for a follower behind the leader too much,
 # so the leader will send logs(snapshot) to the follower,
 # NOTICE, it may cost minutes of time to send a snapshot,
 # so this parameter should be larger than the snapshot cost time.
-catch_up_timeout_ms=300000
+# catch_up_timeout_ms=300000
 
 # whether to use batch append entries in log catch up
-use_batch_in_catch_up=true
+# use_batch_in_catch_up=true
 
 # the minimum number of committed logs in memory, after each log deletion, at most such number of logs
 # will remain in memory. Increasing the number will reduce the chance to use snapshot in catch-ups,
 # but will also increase the memory footprint
-min_num_of_logs_in_mem=1000
+# min_num_of_logs_in_mem=1000
 
 # maximum number of committed logs in memory, when reached, a log deletion will be triggered.
 # Increasing the number will reduce the chance to use snapshot in catch-ups, but will also increase
 # memory footprint
-max_num_of_logs_in_mem=2000
+# max_num_of_logs_in_mem=2000
 
 # maximum memory size of committed logs in memory, when reached, a log deletion will be triggered.
 # Increasing the number will reduce the chance to use snapshot in catch-ups, but will also increase
 # memory footprint, default is 512MB
-max_memory_size_for_raft_log=536870912
+# max_memory_size_for_raft_log=536870912
 
 # deletion check period of the submitted log
-log_deletion_check_interval_second=-1
+# log_deletion_check_interval_second=-1
 
 # Whether creating schema automatically is enabled, this will replace the one in iotdb-engine.properties
-enable_auto_create_schema=true
+# enable_auto_create_schema=true
 
 # consistency level, now three consistency levels are supported: strong, mid, and weak.
 # Strong consistency means the server will first try to synchronize with the leader to get the
 # newest data, if failed(timeout), directly report an error to the user;
 # While mid consistency means the server will first try to synchronize with the leader,
 # but if failed(timeout), it will give up and just use current data it has cached before;
 # Weak consistency does not synchronize with the leader and simply use the local data
-consistency_level=mid
+# consistency_level=mid
 
 # Whether to use asynchronous server
-is_use_async_server=false
+# is_use_async_server=false

Review comment:
       got it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] LebronAl commented on a change in pull request #2993: uncomment the less used configuration

Posted by GitBox <gi...@apache.org>.
LebronAl commented on a change in pull request #2993:
URL: https://github.com/apache/iotdb/pull/2993#discussion_r612070116



##########
File path: cluster/src/assembly/resources/conf/iotdb-cluster.properties
##########
@@ -57,117 +57,117 @@ seed_nodes=127.0.0.1:9003,127.0.0.1:9005,127.0.0.1:9007
 # compression settings for external clients, please modify 'rpc_thrift_compression_enable' in
 # 'iotdb-engine.properties'.
 # WARNING: this must be consistent across all nodes in the cluster
-rpc_thrift_compression_enable=false
+# rpc_thrift_compression_enable=false
 
 # max client connections created by thrift
 # this configuration applies separately to data/meta/client connections and thus does not control
 # the number of global connections
-max_concurrent_client_num=10000
+# max_concurrent_client_num=10000
 
 # number of replications for one partition
 default_replica_num=3
 
 # cluster name to identify different clusters
 # all node's cluster_name in one cluster are the same
-cluster_name=default
+# cluster_name=default
 
 # connection time out (ms) among raft nodes
-connection_timeout_ms=20000
+# connection_timeout_ms=20000
 
 # write operation timeout threshold (ms), this is only for internal communications,
 # not for the whole operation.
-write_operation_timeout_ms=30000
+# write_operation_timeout_ms=30000
 
 # read operation timeout threshold (ms), this is only for internal communications,
 # not for the whole operation.
-read_operation_timeout_ms=30000
+# read_operation_timeout_ms=30000
 
 # catch up timeout threshold (ms), this is used for a follower behind the leader too much,
 # so the leader will send logs(snapshot) to the follower,
 # NOTICE, it may cost minutes of time to send a snapshot,
 # so this parameter should be larger than the snapshot cost time.
-catch_up_timeout_ms=300000
+# catch_up_timeout_ms=300000
 
 # whether to use batch append entries in log catch up
-use_batch_in_catch_up=true
+# use_batch_in_catch_up=true
 
 # the minimum number of committed logs in memory, after each log deletion, at most such number of logs
 # will remain in memory. Increasing the number will reduce the chance to use snapshot in catch-ups,
 # but will also increase the memory footprint
-min_num_of_logs_in_mem=1000
+# min_num_of_logs_in_mem=1000
 
 # maximum number of committed logs in memory, when reached, a log deletion will be triggered.
 # Increasing the number will reduce the chance to use snapshot in catch-ups, but will also increase
 # memory footprint
-max_num_of_logs_in_mem=2000
+# max_num_of_logs_in_mem=2000
 
 # maximum memory size of committed logs in memory, when reached, a log deletion will be triggered.
 # Increasing the number will reduce the chance to use snapshot in catch-ups, but will also increase
 # memory footprint, default is 512MB
-max_memory_size_for_raft_log=536870912
+# max_memory_size_for_raft_log=536870912
 
 # deletion check period of the submitted log
-log_deletion_check_interval_second=-1
+# log_deletion_check_interval_second=-1
 
 # Whether creating schema automatically is enabled, this will replace the one in iotdb-engine.properties
-enable_auto_create_schema=true
+# enable_auto_create_schema=true
 
 # consistency level, now three consistency levels are supported: strong, mid, and weak.
 # Strong consistency means the server will first try to synchronize with the leader to get the
 # newest data, if failed(timeout), directly report an error to the user;
 # While mid consistency means the server will first try to synchronize with the leader,
 # but if failed(timeout), it will give up and just use current data it has cached before;
 # Weak consistency does not synchronize with the leader and simply use the local data
-consistency_level=mid
+# consistency_level=mid
 
 # Whether to use asynchronous server
-is_use_async_server=false
+# is_use_async_server=false

Review comment:
       The ci is broken, we should fix this. This endless ci is mainly because we do not handle the logic right in cluster tests on sync-mode. I partially fixed this problem in this [commit](https://github.com/apache/iotdb/commit/caa8bd6a75f6530734321e209d2339cdf52d3a4a), and further fixes are needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2993: uncomment the less used configuration

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2993:
URL: https://github.com/apache/iotdb/pull/2993#issuecomment-817436542


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2993&metric=coverage&view=list) No Coverage information  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2993&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] qiaojialin merged pull request #2993: uncomment the less used configuration

Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #2993:
URL: https://github.com/apache/iotdb/pull/2993


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #2993: uncomment the less used configuration

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #2993:
URL: https://github.com/apache/iotdb/pull/2993#issuecomment-817436542


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2993&metric=coverage&view=list) No Coverage information  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2993&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] LebronAl commented on a change in pull request #2993: uncomment the less used configuration

Posted by GitBox <gi...@apache.org>.
LebronAl commented on a change in pull request #2993:
URL: https://github.com/apache/iotdb/pull/2993#discussion_r611396540



##########
File path: cluster/src/assembly/resources/conf/iotdb-cluster.properties
##########
@@ -57,117 +57,117 @@ seed_nodes=127.0.0.1:9003,127.0.0.1:9005,127.0.0.1:9007
 # compression settings for external clients, please modify 'rpc_thrift_compression_enable' in
 # 'iotdb-engine.properties'.
 # WARNING: this must be consistent across all nodes in the cluster
-rpc_thrift_compression_enable=false
+# rpc_thrift_compression_enable=false
 
 # max client connections created by thrift
 # this configuration applies separately to data/meta/client connections and thus does not control
 # the number of global connections
-max_concurrent_client_num=10000
+# max_concurrent_client_num=10000
 
 # number of replications for one partition
 default_replica_num=3
 
 # cluster name to identify different clusters
 # all node's cluster_name in one cluster are the same
-cluster_name=default
+# cluster_name=default
 
 # connection time out (ms) among raft nodes
-connection_timeout_ms=20000
+# connection_timeout_ms=20000
 
 # write operation timeout threshold (ms), this is only for internal communications,
 # not for the whole operation.
-write_operation_timeout_ms=30000
+# write_operation_timeout_ms=30000
 
 # read operation timeout threshold (ms), this is only for internal communications,
 # not for the whole operation.
-read_operation_timeout_ms=30000
+# read_operation_timeout_ms=30000
 
 # catch up timeout threshold (ms), this is used for a follower behind the leader too much,
 # so the leader will send logs(snapshot) to the follower,
 # NOTICE, it may cost minutes of time to send a snapshot,
 # so this parameter should be larger than the snapshot cost time.
-catch_up_timeout_ms=300000
+# catch_up_timeout_ms=300000
 
 # whether to use batch append entries in log catch up
-use_batch_in_catch_up=true
+# use_batch_in_catch_up=true
 
 # the minimum number of committed logs in memory, after each log deletion, at most such number of logs
 # will remain in memory. Increasing the number will reduce the chance to use snapshot in catch-ups,
 # but will also increase the memory footprint
-min_num_of_logs_in_mem=1000
+# min_num_of_logs_in_mem=1000
 
 # maximum number of committed logs in memory, when reached, a log deletion will be triggered.
 # Increasing the number will reduce the chance to use snapshot in catch-ups, but will also increase
 # memory footprint
-max_num_of_logs_in_mem=2000
+# max_num_of_logs_in_mem=2000
 
 # maximum memory size of committed logs in memory, when reached, a log deletion will be triggered.
 # Increasing the number will reduce the chance to use snapshot in catch-ups, but will also increase
 # memory footprint, default is 512MB
-max_memory_size_for_raft_log=536870912
+# max_memory_size_for_raft_log=536870912
 
 # deletion check period of the submitted log
-log_deletion_check_interval_second=-1
+# log_deletion_check_interval_second=-1
 
 # Whether creating schema automatically is enabled, this will replace the one in iotdb-engine.properties
-enable_auto_create_schema=true
+# enable_auto_create_schema=true
 
 # consistency level, now three consistency levels are supported: strong, mid, and weak.
 # Strong consistency means the server will first try to synchronize with the leader to get the
 # newest data, if failed(timeout), directly report an error to the user;
 # While mid consistency means the server will first try to synchronize with the leader,
 # but if failed(timeout), it will give up and just use current data it has cached before;
 # Weak consistency does not synchronize with the leader and simply use the local data
-consistency_level=mid
+# consistency_level=mid
 
 # Whether to use asynchronous server
-is_use_async_server=false
+# is_use_async_server=false

Review comment:
       Hi, the `useAsyncServer` is true in `ClusterConfig.java`, so if we commented this parameter out, the cluster will start as aysnc-mode, we'd better make them consistent.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] LebronAl commented on a change in pull request #2993: uncomment the less used configuration

Posted by GitBox <gi...@apache.org>.
LebronAl commented on a change in pull request #2993:
URL: https://github.com/apache/iotdb/pull/2993#discussion_r611396540



##########
File path: cluster/src/assembly/resources/conf/iotdb-cluster.properties
##########
@@ -57,117 +57,117 @@ seed_nodes=127.0.0.1:9003,127.0.0.1:9005,127.0.0.1:9007
 # compression settings for external clients, please modify 'rpc_thrift_compression_enable' in
 # 'iotdb-engine.properties'.
 # WARNING: this must be consistent across all nodes in the cluster
-rpc_thrift_compression_enable=false
+# rpc_thrift_compression_enable=false
 
 # max client connections created by thrift
 # this configuration applies separately to data/meta/client connections and thus does not control
 # the number of global connections
-max_concurrent_client_num=10000
+# max_concurrent_client_num=10000
 
 # number of replications for one partition
 default_replica_num=3
 
 # cluster name to identify different clusters
 # all node's cluster_name in one cluster are the same
-cluster_name=default
+# cluster_name=default
 
 # connection time out (ms) among raft nodes
-connection_timeout_ms=20000
+# connection_timeout_ms=20000
 
 # write operation timeout threshold (ms), this is only for internal communications,
 # not for the whole operation.
-write_operation_timeout_ms=30000
+# write_operation_timeout_ms=30000
 
 # read operation timeout threshold (ms), this is only for internal communications,
 # not for the whole operation.
-read_operation_timeout_ms=30000
+# read_operation_timeout_ms=30000
 
 # catch up timeout threshold (ms), this is used for a follower behind the leader too much,
 # so the leader will send logs(snapshot) to the follower,
 # NOTICE, it may cost minutes of time to send a snapshot,
 # so this parameter should be larger than the snapshot cost time.
-catch_up_timeout_ms=300000
+# catch_up_timeout_ms=300000
 
 # whether to use batch append entries in log catch up
-use_batch_in_catch_up=true
+# use_batch_in_catch_up=true
 
 # the minimum number of committed logs in memory, after each log deletion, at most such number of logs
 # will remain in memory. Increasing the number will reduce the chance to use snapshot in catch-ups,
 # but will also increase the memory footprint
-min_num_of_logs_in_mem=1000
+# min_num_of_logs_in_mem=1000
 
 # maximum number of committed logs in memory, when reached, a log deletion will be triggered.
 # Increasing the number will reduce the chance to use snapshot in catch-ups, but will also increase
 # memory footprint
-max_num_of_logs_in_mem=2000
+# max_num_of_logs_in_mem=2000
 
 # maximum memory size of committed logs in memory, when reached, a log deletion will be triggered.
 # Increasing the number will reduce the chance to use snapshot in catch-ups, but will also increase
 # memory footprint, default is 512MB
-max_memory_size_for_raft_log=536870912
+# max_memory_size_for_raft_log=536870912
 
 # deletion check period of the submitted log
-log_deletion_check_interval_second=-1
+# log_deletion_check_interval_second=-1
 
 # Whether creating schema automatically is enabled, this will replace the one in iotdb-engine.properties
-enable_auto_create_schema=true
+# enable_auto_create_schema=true
 
 # consistency level, now three consistency levels are supported: strong, mid, and weak.
 # Strong consistency means the server will first try to synchronize with the leader to get the
 # newest data, if failed(timeout), directly report an error to the user;
 # While mid consistency means the server will first try to synchronize with the leader,
 # but if failed(timeout), it will give up and just use current data it has cached before;
 # Weak consistency does not synchronize with the leader and simply use the local data
-consistency_level=mid
+# consistency_level=mid
 
 # Whether to use asynchronous server
-is_use_async_server=false
+# is_use_async_server=false

Review comment:
       Hi, the `useAsyncServer` is true in `ClusterConfig.java`, so if we commented this parameter out, the cluster will start as aysnc-mode, we'd better be able to make them consistent again.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] mychaow commented on a change in pull request #2993: uncomment the less used configuration

Posted by GitBox <gi...@apache.org>.
mychaow commented on a change in pull request #2993:
URL: https://github.com/apache/iotdb/pull/2993#discussion_r612164248



##########
File path: cluster/src/assembly/resources/conf/iotdb-cluster.properties
##########
@@ -57,117 +57,117 @@ seed_nodes=127.0.0.1:9003,127.0.0.1:9005,127.0.0.1:9007
 # compression settings for external clients, please modify 'rpc_thrift_compression_enable' in
 # 'iotdb-engine.properties'.
 # WARNING: this must be consistent across all nodes in the cluster
-rpc_thrift_compression_enable=false
+# rpc_thrift_compression_enable=false
 
 # max client connections created by thrift
 # this configuration applies separately to data/meta/client connections and thus does not control
 # the number of global connections
-max_concurrent_client_num=10000
+# max_concurrent_client_num=10000
 
 # number of replications for one partition
 default_replica_num=3
 
 # cluster name to identify different clusters
 # all node's cluster_name in one cluster are the same
-cluster_name=default
+# cluster_name=default
 
 # connection time out (ms) among raft nodes
-connection_timeout_ms=20000
+# connection_timeout_ms=20000
 
 # write operation timeout threshold (ms), this is only for internal communications,
 # not for the whole operation.
-write_operation_timeout_ms=30000
+# write_operation_timeout_ms=30000
 
 # read operation timeout threshold (ms), this is only for internal communications,
 # not for the whole operation.
-read_operation_timeout_ms=30000
+# read_operation_timeout_ms=30000
 
 # catch up timeout threshold (ms), this is used for a follower behind the leader too much,
 # so the leader will send logs(snapshot) to the follower,
 # NOTICE, it may cost minutes of time to send a snapshot,
 # so this parameter should be larger than the snapshot cost time.
-catch_up_timeout_ms=300000
+# catch_up_timeout_ms=300000
 
 # whether to use batch append entries in log catch up
-use_batch_in_catch_up=true
+# use_batch_in_catch_up=true
 
 # the minimum number of committed logs in memory, after each log deletion, at most such number of logs
 # will remain in memory. Increasing the number will reduce the chance to use snapshot in catch-ups,
 # but will also increase the memory footprint
-min_num_of_logs_in_mem=1000
+# min_num_of_logs_in_mem=1000
 
 # maximum number of committed logs in memory, when reached, a log deletion will be triggered.
 # Increasing the number will reduce the chance to use snapshot in catch-ups, but will also increase
 # memory footprint
-max_num_of_logs_in_mem=2000
+# max_num_of_logs_in_mem=2000
 
 # maximum memory size of committed logs in memory, when reached, a log deletion will be triggered.
 # Increasing the number will reduce the chance to use snapshot in catch-ups, but will also increase
 # memory footprint, default is 512MB
-max_memory_size_for_raft_log=536870912
+# max_memory_size_for_raft_log=536870912
 
 # deletion check period of the submitted log
-log_deletion_check_interval_second=-1
+# log_deletion_check_interval_second=-1
 
 # Whether creating schema automatically is enabled, this will replace the one in iotdb-engine.properties
-enable_auto_create_schema=true
+# enable_auto_create_schema=true
 
 # consistency level, now three consistency levels are supported: strong, mid, and weak.
 # Strong consistency means the server will first try to synchronize with the leader to get the
 # newest data, if failed(timeout), directly report an error to the user;
 # While mid consistency means the server will first try to synchronize with the leader,
 # but if failed(timeout), it will give up and just use current data it has cached before;
 # Weak consistency does not synchronize with the leader and simply use the local data
-consistency_level=mid
+# consistency_level=mid
 
 # Whether to use asynchronous server
-is_use_async_server=false
+# is_use_async_server=false

Review comment:
       fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2993: uncomment the less used configuration

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2993:
URL: https://github.com/apache/iotdb/pull/2993#issuecomment-818512960


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2993&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100.png' alt='100.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2993&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2993&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2993&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2993&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org