[jira] [Commented] (BEAM-4393) Missing copyright notices for shaded packages

["Boyuan Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489804#comment-16489804 ] 

Boyuan Zhang commented on BEAM-4393:
------------------------------------

[https://github.com/apache/beam/pull/5472] trying to solve issues as follow:

1. There are some shaded jars(eg. java core) containing NOTICE & LICENSE, but some shaded jars(eg. java harness) not. 
2. The LICENSE included in shaded jar is the default one, not the LICENSE from root repo.

 

> Missing copyright notices for shaded packages
> ---------------------------------------------
>
>                 Key: BEAM-4393
>                 URL: https://issues.apache.org/jira/browse/BEAM-4393
>             Project: Beam
>          Issue Type: Improvement
>          Components: build-system, sdk-java-core
>            Reporter: Scott Wegner
>            Assignee: Boyuan Zhang
>            Priority: Major
>             Fix For: 2.5.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> From [discussion on dev@|https://lists.apache.org/thread.html/6ef6630e908147ee83e1f1efd4befbda43efb2a59271c5cb49473103@%3Cdev.beam.apache.org%3E], it was recently discovered that we are missing copyright notices for packages that we are shading.
> The recommended fix from [~davor] (see linked conversation), is:
> {quote}
>  I'd suggest appending this sentence to the end of the LICENSE file: "A part of several convenience binary distributions of this software is licensed as follows", followed by the full license text (including its copyright, clauses and disclaimer) – for each such case separately. Don't edit the NOTICE file.
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)