You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2012/11/01 16:19:13 UTC
[jira] [Commented] (MAPREDUCE-4762) repair test
org.apache.hadoop.mapreduce.security.token.TestDelegationTokenRenewal
[ https://issues.apache.org/jira/browse/MAPREDUCE-4762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488750#comment-13488750 ]
Daryn Sharp commented on MAPREDUCE-4762:
----------------------------------------
Be very careful because I seem to remember a problem caused by the tests registering the custom token renewer. The believe the test jar is by default in the CLASSPATH, so deploys will load the custom renewer and cause problems.
> repair test org.apache.hadoop.mapreduce.security.token.TestDelegationTokenRenewal
> ---------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4762
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4762
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Ivan A. Veselovsky
>
> The test org.apache.hadoop.mapreduce.security.token.TestDelegationTokenRenewal is @Ignor-ed.
> Due to that several classes in package org.apache.hadoop.mapreduce.security.token have zero unit-test coverage.
> The problem is that the test assumed that class org.apache.hadoop.mapreduce.security.token.TestDelegationTokenRenewal.Renewer is used as a custom implementation of the org.apache.hadoop.security.token.TokenRenewer service, but that did not happen, because this custom service implementation was not registered.
> We solved this problem by using special classloader that is invoked to find the resource META-INF/services/org.apache.hadoop.security.token.TokenRenewer , and supplies some custom content for it. This way the custom service implementation gets instantiated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira