[GitHub] [accumulo] DomGarguilo commented on a diff in pull request #2874: Add empty method to CloneConfiguration API

[GitBox <gi...@apache.org>]

DomGarguilo commented on code in PR #2874:
URL: https://github.com/apache/accumulo/pull/2874#discussion_r943757785


##########
core/src/main/java/org/apache/accumulo/core/client/admin/CloneConfiguration.java:
##########
@@ -98,21 +98,29 @@ public static interface Builder {
      * @param keepOffline
      *          true if the new table is to be kept offline after cloning.
      */
-    public Builder setKeepOffline(boolean keepOffline);
+    Builder setKeepOffline(boolean keepOffline);
 
     /**
      * Build the clone configuration
      *
      * @return the built immutable clone configuration
      */
-    public CloneConfiguration build();
+    CloneConfiguration build();
   }
 
   /**
    * @return a {@link CloneConfiguration} builder
    */
-  public static CloneConfiguration.Builder builder() {
+  static CloneConfiguration.Builder builder() {
     return new CloneConfigurationImpl();
   }
 
+  /**
+   * @return an empty configuration object with the default settings.
+   * @since 2.1.0
+   */
+  static CloneConfiguration empty() {

Review Comment:
   Could a more descriptive method name be used here? Maybe something along the lines of `emptyConfig` or `getEmptyCloneConfig`? Regardless, these changes LGTM



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org