You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/03/31 23:22:14 UTC

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8445: add metric for largest segment size

Jackie-Jiang commented on a change in pull request #8445:
URL: https://github.com/apache/pinot/pull/8445#discussion_r840098406



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java
##########
@@ -70,6 +70,8 @@
   @Deprecated // Instead use TABLE_TOTAL_SIZE_ON_SERVER
   OFFLINE_TABLE_ESTIMATED_SIZE("OfflineTableEstimatedSize", false),
 
+  LARGEST_SEGMENT_SIZE_ON_DISK("LargestSegmentSizeOnDisk", false),

Review comment:
       ```suggestion
     LARGEST_SEGMENT_SIZE_ON_SERVER("LargestSegmentSizeOnServer", false),
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org