[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4682: Clean up docker integration test and add documentation

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #4682:
URL: https://github.com/apache/trafficcontrol/pull/4682#discussion_r420326721



##########
File path: docs/source/admin/quick_howto/ciab.rst
##########
@@ -104,6 +104,21 @@ In order to check the "readiness" of your CDN, you can optionally start the Read
 
 	sudo docker-compose -f docker-compose.readiness.yml up
 
+Integration Tests
+"""""""""""""""""
+
+There also exists TP and TO integration tests containers. Both of these containers assume that CDN in a Box is already running on the local system.

Review comment:
       s/exists/exist/

##########
File path: infrastructure/cdn-in-a-box/traffic_portal_integration_test/Dockerfile
##########
@@ -31,21 +31,13 @@ gpgkey=https://dl-ssl.google.com/linux/linux_signing_key.pub \n\
 " > /etc/yum.repos.d/google-chrome.repo
 
 RUN yum update -y
-
 RUN yum install -y java-1.8.0-openjdk git google-chrome-stable bind-utils net-tools
-
-RUN curl -LO https://nodejs.org/dist/v12.16.3/node-v12.16.3-linux-x64.tar.xz

Review comment:
       Doesn't getting rid of this cause the subsequent `npm install` steps to fail?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org