You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Bilung Lee <bl...@gmail.com> on 2012/08/03 20:35:42 UTC
Re: Review Request: SQOOP-531: Define connector execution lifecycle
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6291/
-----------------------------------------------------------
(Updated Aug. 3, 2012, 6:35 p.m.)
Review request for Sqoop.
Summary (updated)
-----------------
SQOOP-531: Define connector execution lifecycle
Description
-------
Define classes needed for Sqoop 2 connector execution lifecycle.
This addresses bug SQOOP-531.
https://issues.apache.org/jira/browse/SQOOP-531
Diffs
-----
branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 1367789
branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java PRE-CREATION
branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java PRE-CREATION
branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java PRE-CREATION
branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportDestroyer.java PRE-CREATION
branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java PRE-CREATION
branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java PRE-CREATION
branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java PRE-CREATION
branches/sqoop2/connector/connector-mysql-jdbc/src/main/java/org/apache/sqoop/connector/mysqljdbc/MySqlJdbcConnector.java 1367789
branches/sqoop2/spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 1367789
branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java PRE-CREATION
branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Exporter.java PRE-CREATION
branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java PRE-CREATION
branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Importer.java PRE-CREATION
branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java PRE-CREATION
branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Loader.java PRE-CREATION
branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java PRE-CREATION
Diff: https://reviews.apache.org/r/6291/diff/
Testing
-------
Thanks,
Bilung Lee
Re: Review Request: SQOOP-531: Define connector execution lifecycle
Posted by Bilung Lee <bl...@gmail.com>.
> On Aug. 3, 2012, 10:51 p.m., Jarek Cecho wrote:
> > Proposal looks good to me Bilung. Please attach your patch to the JIRA and I'll commit it.
Thanks for your review! Patch is attached to JIRA and feel free to commit.
- Bilung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6291/#review9839
-----------------------------------------------------------
On Aug. 3, 2012, 6:35 p.m., Bilung Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6291/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2012, 6:35 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Define classes needed for Sqoop 2 connector execution lifecycle.
>
>
> This addresses bug SQOOP-531.
> https://issues.apache.org/jira/browse/SQOOP-531
>
>
> Diffs
> -----
>
> branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 1367789
> branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java PRE-CREATION
> branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java PRE-CREATION
> branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java PRE-CREATION
> branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportDestroyer.java PRE-CREATION
> branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java PRE-CREATION
> branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java PRE-CREATION
> branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java PRE-CREATION
> branches/sqoop2/connector/connector-mysql-jdbc/src/main/java/org/apache/sqoop/connector/mysqljdbc/MySqlJdbcConnector.java 1367789
> branches/sqoop2/spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 1367789
> branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java PRE-CREATION
> branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Exporter.java PRE-CREATION
> branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java PRE-CREATION
> branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Importer.java PRE-CREATION
> branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java PRE-CREATION
> branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Loader.java PRE-CREATION
> branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/6291/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bilung Lee
>
>
Re: Review Request: SQOOP-531: Define connector execution lifecycle
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6291/#review9839
-----------------------------------------------------------
Ship it!
Proposal looks good to me Bilung. Please attach your patch to the JIRA and I'll commit it.
- Jarek Cecho
On Aug. 3, 2012, 6:35 p.m., Bilung Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6291/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2012, 6:35 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Define classes needed for Sqoop 2 connector execution lifecycle.
>
>
> This addresses bug SQOOP-531.
> https://issues.apache.org/jira/browse/SQOOP-531
>
>
> Diffs
> -----
>
> branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 1367789
> branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java PRE-CREATION
> branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java PRE-CREATION
> branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java PRE-CREATION
> branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportDestroyer.java PRE-CREATION
> branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java PRE-CREATION
> branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java PRE-CREATION
> branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java PRE-CREATION
> branches/sqoop2/connector/connector-mysql-jdbc/src/main/java/org/apache/sqoop/connector/mysqljdbc/MySqlJdbcConnector.java 1367789
> branches/sqoop2/spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 1367789
> branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java PRE-CREATION
> branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Exporter.java PRE-CREATION
> branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java PRE-CREATION
> branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Importer.java PRE-CREATION
> branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java PRE-CREATION
> branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Loader.java PRE-CREATION
> branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/6291/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bilung Lee
>
>