You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Sohan Jain <so...@fb.com> on 2011/08/11 01:31:28 UTC

Review Request: HIVE-2368: Determining whether a Column Descriptor is unused may take too long

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1462/
-----------------------------------------------------------

Review request for hive and Paul Yang.


Summary
-------

To determine if a column descriptor is unused, we call listStorageDescriptorsWithCD(), which may return a big list of SDs. This can severely slow down dropping partitions.

We can add a maximum number of SDs to return, and just ask for 1 SD, since we are just doing an existential check.


This addresses bug HIVE-2368.
    https://issues.apache.org/jira/browse/HIVE-2368


Diffs
-----

  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1156401 

Diff: https://reviews.apache.org/r/1462/diff


Testing
-------


Thanks,

Sohan