You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/07/18 11:20:15 UTC
[Bug 122778] New: [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
https://issues.apache.org/ooo/show_bug.cgi?id=122778
Bug ID: 122778
Issue Type: DEFECT
Summary: [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Product: Impress
Version: AOO400-dev
Hardware: All
OS: Unix, all
Status: CONFIRMED
Severity: normal
Priority: P3
Component: editing
Assignee: issues@openoffice.apache.org
Reporter: Armin.Le.Grand@me.com
CC: issues@openoffice.apache.org
ALG: Due to the now used DrawTransformedBitmap not being supported on
system-level on Linux (X-Servers) a fallback is used who's quality needs
improvement. It supports smoothing, but this is not activated.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |4.0.1_release_blocker?
--- Comment #12 from Armin Le Grand <Ar...@me.com> ---
ALG: Requesting the AOO401 flag...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |regression
--- Comment #5 from Armin Le Grand <Ar...@me.com> ---
ALG: Adding the regression keyword, copied from original task
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
--- Comment #7 from Armin Le Grand <Ar...@me.com> ---
ALG: Checked the linux version with these changes; faster, better scrolling,
but still the bad edges. These do *not* come from the created, self-transformed
bitmap, but from painting this scaled when the point limit is reached (there is
a maximum square pixels to take into account). When removing this, edges are
smooth since the self-prepared transformed bitmap will be the exactly paint
size, so no scaling in software in vcl is done anymore.
@HDU: Problem emerges in OutputDevice::ImplDrawAlpha; the scaling done there is
very rough and produces those bad edges. To switch off size limitation in the
creation of self-transformed bitmaps, apply the patch and in
BitmapEx::getTransformed let bNeedToReduce never get true.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
--- Comment #2 from Armin Le Grand <Ar...@me.com> ---
ALG: This is strange; when I force Win to also use the fallback method, the
graphic gets smoothed nicely. What's going wrong on the Linux version?
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
jsc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.0.1
--- Comment #16 from jsc@apache.org ---
set target milestone
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |ACCEPTED
--- Comment #8 from Armin Le Grand <Ar...@me.com> ---
ALG: Checked that indeed OutputDevice::ImplDrawAlpha also creates another
temporary bitmap when source and target scaling is different, so the best
solution will be to not use a maximum pixel limit in the case that the target
is a window output device; this will need the restrictions of the already added
patch so that it cannot get bigger than the actual output area. Trying out...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ACCEPTED |RESOLVED
Resolution|--- |FIXED
--- Comment #11 from Armin Le Grand <Ar...@me.com> ---
ALG: Checked on Linux, looks good and works well, may be added to AOO401.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
--- Comment #10 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1517803 into trunk:
i122778 Enhanced own transformer for drawing transformed bitmaps which is
use...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|issues@openoffice.apache.or |Armin.Le.Grand@me.com
|g |
--- Comment #1 from Armin Le Grand <Ar...@me.com> ---
ALG: Grepping
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
fanyuzhen@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fanyuzhen@gmail.com
--- Comment #17 from fanyuzhen@gmail.com ---
The latest build in wiki is AOO401m1(Build:9710) - Rev. 1516414, wait for
revision 1518625 for verification
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
--- Comment #3 from hdu@apache.org <hd...@apache.org> ---
Created attachment 81106
--> https://issues.apache.org/ooo/attachment.cgi?id=81106&action=edit
sample document which clearly shows the problem
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
jsc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jsc@apache.org
Flags|4.0.1_release_blocker? |4.0.1_release_blocker+
--- Comment #13 from jsc@apache.org ---
approve showstopper request
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
4.0.1_release_blocker granted: [Bug 122778] [Fup 122758] Linux
display quality of transformed bitmaps needs improvement
Posted by bu...@apache.org.
jsc@apache.org has granted Armin Le Grand <Ar...@me.com>'s request for
4.0.1_release_blocker:
Bug 122778: [Fup 122758] Linux display quality of transformed bitmaps needs
improvement
https://issues.apache.org/ooo/show_bug.cgi?id=122778
------- Additional Comments from jsc@apache.org
approve showstopper request
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
--- Comment #6 from Armin Le Grand <Ar...@me.com> ---
Created attachment 81331
--> https://issues.apache.org/ooo/attachment.cgi?id=81331&action=edit
Patch with experiments for better and faster sclaing
ALG: Saving unfinished work by adding that patch. It is not finished, a
in-between result of forcing the local bitmap transformator to be used on win
for debugging.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
--- Comment #9 from Armin Le Grand <Ar...@me.com> ---
ALG: Re-started with the applied patch, extended and added better max square
pixel bounds for rendering. This is used for all systems where no direct
support for transformed graphics is added (Linux currently) and works better
now by smoothing better and only preparing visible parts. The patch is bigger
than is good for AOO401, but in principle not dangerous. Comitted as r1517803,
still thinking about a simple solution for AOO401...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
liupingtan <do...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
CC| |doneyourself@gmail.com
--- Comment #18 from liupingtan <do...@gmail.com> ---
Verified on AOO401m2(Build:9711) - Rev. 1518667
2013-08-20 14:23:59 (Tue, 20 Aug 2013) - MacOS 10.8 ,Pass
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
hdu@apache.org <hd...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hdu@apache.org
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
hdu@apache.org <hd...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |122796
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
Bug 122778 depends on bug 122796, which changed state.
Bug 122796 Summary: Half-pixel offset in scaled images
https://issues.apache.org/ooo/show_bug.cgi?id=122796
What |Removed |Added
----------------------------------------------------------------------------
Status|ACCEPTED |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
--- Comment #15 from Armin Le Grand <Ar...@me.com> ---
ALG: Checked and added to AOO401
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
4.0.1_release_blocker requested: [Bug 122778] [Fup 122758] Linux
display quality of transformed bitmaps needs improvement
Posted by bu...@apache.org.
Armin Le Grand <Ar...@me.com> has asked for 4.0.1_release_blocker:
Bug 122778: [Fup 122758] Linux display quality of transformed bitmaps needs
improvement
https://issues.apache.org/ooo/show_bug.cgi?id=122778
------- Additional Comments from Armin Le Grand <Ar...@me.com>
ALG: Requesting the AOO401 flag...
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
--- Comment #4 from hdu@apache.org <hd...@apache.org> ---
The difference seems to be that previously the interpolation-scaled image was
rotated whereas now the impSmoothPoint() method uses only up to four
neighboring sample pixels to get a target pixel. Especially when the ratio of
source to destination sizes is big that sampling method results in pronounced
Moiré artifacts.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 122778] [Fup 122758] Linux display quality of transformed
bitmaps needs improvement
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122778
--- Comment #14 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1518625 into branches/AOO401:
i122778 Enhanced own transformer for drawing transformed bitmaps
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.