You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Andrej Aschenbrenner (JIRA)" <ji...@apache.org> on 2009/04/02 12:32:12 UTC

[jira] Created: (TAP5-616) Hidden component does not properly decode submitted data

Hidden component does not properly decode submitted data
--------------------------------------------------------

                 Key: TAP5-616
                 URL: https://issues.apache.org/jira/browse/TAP5-616
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-core
    Affects Versions: 5.1.0.2
            Reporter: Andrej Aschenbrenner


In the new Hidden component in method:

    private void processSubmission(String controlName)
    {
        String encoded = request.getParameter(controlName);

        Object decoded = encoder.toClient(encoded);

        value = decoded;
    }

the line
Object decoded = encoder.toClient(encoded);
should be
Object decoded = encoder.toValue(encoded);

Thanks,
Andrej Aschenbrenner




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TAP5-616) Hidden component does not properly decode submitted data

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695027#action_12695027 ] 

Howard M. Lewis Ship commented on TAP5-616:
-------------------------------------------

Oops. I can see how the test missed that ... the component did the wrong thing but in this case, the TypeCoercer (that is implicitly used when updating a parameter field) took up the slack.

> Hidden component does not properly decode submitted data
> --------------------------------------------------------
>
>                 Key: TAP5-616
>                 URL: https://issues.apache.org/jira/browse/TAP5-616
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.1.0.2
>            Reporter: Andrej Aschenbrenner
>
> In the new Hidden component in method:
>     private void processSubmission(String controlName)
>     {
>         String encoded = request.getParameter(controlName);
>         Object decoded = encoder.toClient(encoded);
>         value = decoded;
>     }
> the line
> Object decoded = encoder.toClient(encoded);
> should be
> Object decoded = encoder.toValue(encoded);
> Thanks,
> Andrej Aschenbrenner

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (TAP5-616) Hidden component does not properly decode submitted data

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-616.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.1.0.3

> Hidden component does not properly decode submitted data
> --------------------------------------------------------
>
>                 Key: TAP5-616
>                 URL: https://issues.apache.org/jira/browse/TAP5-616
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.1.0.2
>            Reporter: Andrej Aschenbrenner
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.1.0.3
>
>
> In the new Hidden component in method:
>     private void processSubmission(String controlName)
>     {
>         String encoded = request.getParameter(controlName);
>         Object decoded = encoder.toClient(encoded);
>         value = decoded;
>     }
> the line
> Object decoded = encoder.toClient(encoded);
> should be
> Object decoded = encoder.toValue(encoded);
> Thanks,
> Andrej Aschenbrenner

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (TAP5-616) Hidden component does not properly decode submitted data

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAP5-616:
-----------------------------------------

    Assignee: Howard M. Lewis Ship

> Hidden component does not properly decode submitted data
> --------------------------------------------------------
>
>                 Key: TAP5-616
>                 URL: https://issues.apache.org/jira/browse/TAP5-616
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.1.0.2
>            Reporter: Andrej Aschenbrenner
>            Assignee: Howard M. Lewis Ship
>
> In the new Hidden component in method:
>     private void processSubmission(String controlName)
>     {
>         String encoded = request.getParameter(controlName);
>         Object decoded = encoder.toClient(encoded);
>         value = decoded;
>     }
> the line
> Object decoded = encoder.toClient(encoded);
> should be
> Object decoded = encoder.toValue(encoded);
> Thanks,
> Andrej Aschenbrenner

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TAP5-616) Hidden component does not properly decode submitted data

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695027#action_12695027 ] 

Howard M. Lewis Ship commented on TAP5-616:
-------------------------------------------

Oops. I can see how the test missed that ... the component did the wrong thing but in this case, the TypeCoercer (that is implicitly used when updating a parameter field) took up the slack.

> Hidden component does not properly decode submitted data
> --------------------------------------------------------
>
>                 Key: TAP5-616
>                 URL: https://issues.apache.org/jira/browse/TAP5-616
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.1.0.2
>            Reporter: Andrej Aschenbrenner
>
> In the new Hidden component in method:
>     private void processSubmission(String controlName)
>     {
>         String encoded = request.getParameter(controlName);
>         Object decoded = encoder.toClient(encoded);
>         value = decoded;
>     }
> the line
> Object decoded = encoder.toClient(encoded);
> should be
> Object decoded = encoder.toValue(encoded);
> Thanks,
> Andrej Aschenbrenner

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (TAP5-616) Hidden component does not properly decode submitted data

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAP5-616:
-----------------------------------------

    Assignee: Howard M. Lewis Ship

> Hidden component does not properly decode submitted data
> --------------------------------------------------------
>
>                 Key: TAP5-616
>                 URL: https://issues.apache.org/jira/browse/TAP5-616
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.1.0.2
>            Reporter: Andrej Aschenbrenner
>            Assignee: Howard M. Lewis Ship
>
> In the new Hidden component in method:
>     private void processSubmission(String controlName)
>     {
>         String encoded = request.getParameter(controlName);
>         Object decoded = encoder.toClient(encoded);
>         value = decoded;
>     }
> the line
> Object decoded = encoder.toClient(encoded);
> should be
> Object decoded = encoder.toValue(encoded);
> Thanks,
> Andrej Aschenbrenner

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (TAP5-616) Hidden component does not properly decode submitted data

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-616.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.1.0.3

> Hidden component does not properly decode submitted data
> --------------------------------------------------------
>
>                 Key: TAP5-616
>                 URL: https://issues.apache.org/jira/browse/TAP5-616
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.1.0.2
>            Reporter: Andrej Aschenbrenner
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.1.0.3
>
>
> In the new Hidden component in method:
>     private void processSubmission(String controlName)
>     {
>         String encoded = request.getParameter(controlName);
>         Object decoded = encoder.toClient(encoded);
>         value = decoded;
>     }
> the line
> Object decoded = encoder.toClient(encoded);
> should be
> Object decoded = encoder.toValue(encoded);
> Thanks,
> Andrej Aschenbrenner

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.