You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/10/01 11:57:51 UTC
[GitHub] janpio commented on a change in pull request #159: iPhone XR, XS,
XSMax Support
janpio commented on a change in pull request #159: iPhone XR, XS, XSMax Support
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/159#discussion_r221582468
##########
File path: src/ios/CDVSplashScreen.m
##########
@@ -175,7 +181,8 @@ - (CDV_iOSDevice) getCurrentDevice
device.iPhone6 = (device.iPhone && limit == 667.0);
device.iPhone6Plus = (device.iPhone && limit == 736.0);
device.iPhoneX = (device.iPhone && limit == 812.0);
-
+ device.iPhoneXSMax = (device.iPhone && limitNativ == 2688.0);
Review comment:
typo?
should probably be `limitNative` or `limit`?
(same in line below)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org