You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/02/29 05:06:27 UTC
[PR] fix api/japi links in build.sbt [incubator-pekko-http]
pjfanning opened a new pull request, #496:
URL: https://github.com/apache/incubator-pekko-http/pull/496
japi is for javadoc - api is for scaladoc - we have them the wrong way around in build.sbt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix api/japi links in build.sbt [incubator-pekko-http]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on code in PR #496:
URL: https://github.com/apache/incubator-pekko-http/pull/496#discussion_r1507041296
##########
scripts/link-validator.conf:
##########
@@ -64,6 +64,7 @@ site-link-validator {
"http://localhost:8080"
# broken URL in license report
"http://pholser.github.com/"
+ "http://specs2.org/"
Review Comment:
Ah...I can't visit this website. Why add this?
maybe
https://etorreborre.github.io/specs2/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix api/japi links in build.sbt [incubator-pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #496:
URL: https://github.com/apache/incubator-pekko-http/pull/496#discussion_r1507042504
##########
scripts/link-validator.conf:
##########
@@ -64,6 +64,7 @@ site-link-validator {
"http://localhost:8080"
# broken URL in license report
"http://pholser.github.com/"
+ "http://specs2.org/"
Review Comment:
the license-report.html is generated - we don't really get to control what goes in it
that specs.org is what it is linking to and it now seems to be broken
so that means I need to get the validator to ignore it - that is what this setting is for
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix api/japi links in build.sbt [incubator-pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #496:
URL: https://github.com/apache/incubator-pekko-http/pull/496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix api/japi links in build.sbt [incubator-pekko-http]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on code in PR #496:
URL: https://github.com/apache/incubator-pekko-http/pull/496#discussion_r1507057061
##########
scripts/link-validator.conf:
##########
@@ -64,6 +64,7 @@ site-link-validator {
"http://localhost:8080"
# broken URL in license report
"http://pholser.github.com/"
+ "http://specs2.org/"
Review Comment:
Thank you for your explanation. It may be an issue with specs2, and there may be an issue with their domain DNS.
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org